Bug 149894

Summary:

Make the site name configurable in perf dashboard

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

Perf Dashboard

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, dewei_zhu, jond, kling, koivisto, rniwa, timothy

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Fixes the bug	cdumez: review+

Description Ryosuke Niwa 2015-10-07 13:52:57 PDT

Right now, we have to modify HTML files to change the app name.
We should make it configurable through config.json.

Comment 1 Ryosuke Niwa 2015-10-07 14:01:04 PDT

Created attachment 262640 [details]
Fixes the bug

Comment 2 Chris Dumez 2015-10-07 14:05:15 PDT

Comment on attachment 262640 [details]
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=262640&action=review

r=me with comments.

> Websites/perf.webkit.org/public/index.html:1224
> +        document.querySelector('h1 a').textContent = manifest.siteTitle;

May be nicer / more robust to have an id for the <a> element.

> Websites/perf.webkit.org/public/index.html:1237
> +<h1><a href="/"></a></h1>

I would keep "Perf Monitor" in there (similarly to what you did for the title), just for readability, even though it does not matter in practice.

Comment 3 Ryosuke Niwa 2015-10-07 14:23:43 PDT

Thanks for the reviews!

Comment 4 Ryosuke Niwa 2015-10-07 14:25:21 PDT

Committed r190687: <http://trac.webkit.org/changeset/190687>