Bug 149894

Summary: Make the site name configurable in perf dashboard
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Perf DashboardAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, dewei_zhu, jond, kling, koivisto, rniwa, timothy
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Fixes the bug cdumez: review+

Ryosuke Niwa
Reported 2015-10-07 13:52:57 PDT
Right now, we have to modify HTML files to change the app name. We should make it configurable through config.json.
Attachments
Fixes the bug (5.17 KB, patch)
2015-10-07 14:01 PDT, Ryosuke Niwa 		cdumez: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2015-10-07 14:01:04 PDT
Created attachment 262640 [details] Fixes the bug
Chris Dumez
Comment 2 2015-10-07 14:05:15 PDT
Comment on attachment 262640 [details] Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=262640&action=review r=me with comments. > Websites/perf.webkit.org/public/index.html:1224 > + document.querySelector('h1 a').textContent = manifest.siteTitle; May be nicer / more robust to have an id for the <a> element. > Websites/perf.webkit.org/public/index.html:1237 > +<h1><a href="/"></a></h1> I would keep "Perf Monitor" in there (similarly to what you did for the title), just for readability, even though it does not matter in practice.
Ryosuke Niwa
Comment 3 2015-10-07 14:23:43 PDT
Thanks for the reviews!
Ryosuke Niwa
Comment 4 2015-10-07 14:25:21 PDT
Committed r190687: <http://trac.webkit.org/changeset/190687>
Note You need to log in before you can comment on or make changes to this bug.