| Summary: | [CSS Grid Layout] Fix grid-{row, column, area} shorthand CSSOM serialization | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Javier Fernandez <jfernandez> | ||||
| Component: | Layout and Rendering | Assignee: | Javier Fernandez <jfernandez> | ||||
| Status: | NEW --- | ||||||
| Severity: | Normal | CC: | ahmad.saleem792, clopez, darin, jfernandez, rego, simon.fraser, svillar, zalan | ||||
| Priority: | P2 | Keywords: | BlinkMergeCandidate | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=204506 | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 149891 | ||||||
| Attachments: |
|
||||||
|
Description
Javier Fernandez
2015-10-07 13:16:05 PDT
Fixing this bug would require to merge http://crrev.com/1132753002 patch. Created attachment 262632 [details]
Patch
Comment on attachment 262632 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=262632&action=review > Source/WebCore/css/CSSPropertyNames.in:493 > +-webkit-grid-area [Longhands=-webkit-grid-row-start|-webkit-grid-column-start|-webkit-grid-row-end|-webkit-grid-column-end] Wow this is bad. This means that we're expanding incorrectly the shorthand and that we have no tests to verify that. Please use a different bug to upload this change with its corresponding test. I think this is causing failures on the WPT test https://wpt.live/css/css-grid/parsing/grid-area-valid.html (In reply to Carlos Alberto Lopez Perez from comment #4) > I think this is causing failures on the WPT test > https://wpt.live/css/css-grid/parsing/grid-area-valid.html In this above test case: Safari 16 -> 24 Pass and 32 Fail Safari TP 154 -> 24 Pass and 32 Fail Chrome Canary 108 -> 24 Pass and 32 Fail Firefox Nightly 107 -> 56 Pass |