Bug 149887

Summary: Add -[WKProcessPool _setObjectsForBundleParametersWithDictionary:]
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ossy, thorton
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch thorton: review+

Anders Carlsson
Reported 2015-10-07 12:18:48 PDT
Add -[WKProcessPool _setObjectsForBundleParametersWithDictionary:]
Attachments
Patch (10.77 KB, patch)
2015-10-07 12:27 PDT, Anders Carlsson 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2015-10-07 12:27:17 PDT
Created attachment 262624 [details] Patch
WebKit Commit Bot
Comment 2 2015-10-07 12:28:31 PDT
Attachment 262624 [details] did not pass style-queue: ERROR: Source/WebKit2/WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:192: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit2/WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:192: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessBundleParameters.mm:66: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKProcessPool.mm:202: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKProcessPool.mm:202: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 5 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 3 2015-10-07 12:40:54 PDT
Committed r190678: <http://trac.webkit.org/changeset/190678>
Csaba Osztrogonác
Comment 4 2015-10-07 15:09:05 PDT
and the buildfix landed in https://trac.webkit.org/changeset/190691
Note You need to log in before you can comment on or make changes to this bug.