Bug 149887 - Add -[WKProcessPool _setObjectsForBundleParametersWithDictionary:]
Summary: Add -[WKProcessPool _setObjectsForBundleParametersWithDictionary:]
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-07 12:18 PDT by Anders Carlsson
Modified: 2015-10-07 15:09 PDT (History)
3 users (show)

See Also:

Attachments
Patch (10.77 KB, patch)
2015-10-07 12:27 PDT, Anders Carlsson 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2015-10-07 12:18:48 PDT 
Add -[WKProcessPool _setObjectsForBundleParametersWithDictionary:]
Comment 1 Anders Carlsson 2015-10-07 12:27:17 PDT 
Created attachment 262624 [details]
Patch
Comment 2 WebKit Commit Bot 2015-10-07 12:28:31 PDT 
Attachment 262624 [details] did not pass style-queue:


ERROR: Source/WebKit2/WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:192:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:192:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessBundleParameters.mm:66:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKProcessPool.mm:202:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKProcessPool.mm:202:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 5 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Anders Carlsson 2015-10-07 12:40:54 PDT 
Committed r190678: <http://trac.webkit.org/changeset/190678>
Comment 4 Csaba Osztrogonác 2015-10-07 15:09:05 PDT 
and the buildfix landed in https://trac.webkit.org/changeset/190691