Summary: | JIT::emitGetGlobalProperty/emitPutGlobalProperty are only called from one place | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||
Component: | JavaScriptCore | Assignee: | Filip Pizlo <fpizlo> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | barraclough, benjamin, commit-queue, ggaren, mark.lam, mhahnenb, msaboff, nrotem, oliver, saam, sam | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 149852 | ||||||
Attachments: |
|
Description
Filip Pizlo
2015-10-07 11:10:37 PDT
Created attachment 262616 [details]
the patch
Comment on attachment 262616 [details]
the patch
lgtm
Attachment 262616 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/jit/JITPropertyAccess.cpp:785: Non-label code inside switch statements should be indented. [whitespace/indent] [4]
Total errors found: 1 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
I've got build fixes for everything locally. Landed in http://trac.webkit.org/changeset/190675 The version of this that I ladned had the fix for 64-bit. Landed in http://trac.webkit.org/changeset/190675 |