Bug 149879 - JIT::emitGetGlobalProperty/emitPutGlobalProperty are only called from one place
Summary: JIT::emitGetGlobalProperty/emitPutGlobalProperty are only called from one place
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 149852
  Show dependency treegraph
 
Reported: 2015-10-07 11:10 PDT by Filip Pizlo
Modified: 2015-10-07 12:07 PDT (History)
11 users (show)

See Also:


Attachments
the patch (11.72 KB, patch)
2015-10-07 11:12 PDT, Filip Pizlo
sbarati: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2015-10-07 11:10:37 PDT
They should be inlined.
Comment 1 Filip Pizlo 2015-10-07 11:12:48 PDT
Created attachment 262616 [details]
the patch
Comment 2 Saam Barati 2015-10-07 11:14:21 PDT
Comment on attachment 262616 [details]
the patch

lgtm
Comment 3 WebKit Commit Bot 2015-10-07 11:14:30 PDT
Attachment 262616 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/jit/JITPropertyAccess.cpp:785:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Filip Pizlo 2015-10-07 11:18:25 PDT
I've got build fixes for everything locally.
Comment 5 Filip Pizlo 2015-10-07 11:27:37 PDT
Landed in http://trac.webkit.org/changeset/190675

The version of this that I ladned had the fix for 64-bit.
Comment 6 Filip Pizlo 2015-10-07 12:07:57 PDT
Landed in http://trac.webkit.org/changeset/190675