Bug 149876 – [css-grid] Include freeSpace in GridSizingData struct

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Sergio Villar Senin]

We're passing freeSpaceForRows and freeSpaceForColumns to a bunch of functions along with the GridSizingData struct when we should really include them both in the struct as we're talking about temporary data that is only used for the layout process.

[Sergio Villar Senin]

Created attachment 262610 [details]
Patch

[Darin Adler]

Comment on attachment 262610 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262610&action=review

Need a new patch; looks like this one doesn’t build.

> Source/WebCore/rendering/RenderGrid.cpp:214
> +    GridSizingData(unsigned gridColumnCount, unsigned gridRowCount, const LayoutUnit& freeSpaceForColumns, const LayoutUnit& freeSpaceForRows)

LayoutUnit is small enough that we probably want to just pass LayoutUnit, not const LayoutUnit&.

> Source/WebCore/rendering/RenderGrid.cpp:358
> +    const_cast<RenderGrid*>(this)->computeUsedBreadthOfGridTracks(ForColumns, sizingData);

The const_cast in this function is strange. Doesn’t seem like the right pattern for functions with side effects. Not new to this patch, though.

[Sergio Villar Senin]

(In reply to comment #2)
> Comment on attachment 262610 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=262610&action=review
> 
> Need a new patch; looks like this one doesn’t build.

Beh, I somehow committed a patch without one of the replacements.

[Sergio Villar Senin]

Created attachment 262688 [details]
Patch

[Sergio Villar Senin]

Committed r190784: <http://trac.webkit.org/changeset/190784>