Bug 149870 – Perf dashboard doesn't show analysis tasks anchored at outliers

• Component: Perf Dashboard
• Status: RESOLVED FIXED

[Ryosuke Niwa]

When data points selected as end-points for an analysis task are marked as outliers,
the dashboard doesn't show those analysis tasks on the charts.

(Furthermore, we throw an exception if my monkey-patch wasn't applied).

[Ryosuke Niwa]

Created attachment 262586 [details]
Fixes the bug

[Chris Dumez]

Comment on attachment 262586 [details]
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=262586&action=review

rs=me

> Websites/perf.webkit.org/public/v2/app.js:446
> +                return (+firstPoint.time + +secondPoint.time) / 2;

What's the purpose of the extra '+' signs?

[Ryosuke Niwa]

Comment on attachment 262586 [details]
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=262586&action=review

>> Websites/perf.webkit.org/public/v2/app.js:446
>> +                return (+firstPoint.time + +secondPoint.time) / 2;
> 
> What's the purpose of the extra '+' signs?

It converts Date objects to numbers.

[WebKit Commit Bot]

Comment on attachment 262586 [details]
Fixes the bug

Clearing flags on attachment: 262586

Committed r190676: <http://trac.webkit.org/changeset/190676>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.