Bug 149870

Summary:

Perf dashboard doesn't show analysis tasks anchored at outliers

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

Perf Dashboard

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, commit-queue, dewei_zhu, jond, kling, rniwa, timothy

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Fixes the bug	none

Description Ryosuke Niwa 2015-10-06 23:39:43 PDT

When data points selected as end-points for an analysis task are marked as outliers,
the dashboard doesn't show those analysis tasks on the charts.

(Furthermore, we throw an exception if my monkey-patch wasn't applied).

Comment 1 Ryosuke Niwa 2015-10-06 23:56:43 PDT

Created attachment 262586 [details]
Fixes the bug

Comment 2 Chris Dumez 2015-10-07 09:20:08 PDT

Comment on attachment 262586 [details]
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=262586&action=review

rs=me

> Websites/perf.webkit.org/public/v2/app.js:446
> +                return (+firstPoint.time + +secondPoint.time) / 2;

What's the purpose of the extra '+' signs?

Comment 3 Ryosuke Niwa 2015-10-07 10:54:01 PDT

Comment on attachment 262586 [details]
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=262586&action=review

>> Websites/perf.webkit.org/public/v2/app.js:446
>> +                return (+firstPoint.time + +secondPoint.time) / 2;
> 
> What's the purpose of the extra '+' signs?

It converts Date objects to numbers.

Comment 4 WebKit Commit Bot 2015-10-07 11:38:38 PDT

Comment on attachment 262586 [details]
Fixes the bug

Clearing flags on attachment: 262586

Committed r190676: <http://trac.webkit.org/changeset/190676>

Comment 5 WebKit Commit Bot 2015-10-07 11:38:43 PDT

All reviewed patches have been landed.  Closing bug.