Bug 149870 - Perf dashboard doesn't show analysis tasks anchored at outliers
Summary: Perf dashboard doesn't show analysis tasks anchored at outliers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Perf Dashboard (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-06 23:39 PDT by Ryosuke Niwa
Modified: 2016-02-16 13:53 PST (History)
7 users (show)

See Also:

Attachments
Fixes the bug (11.46 KB, patch)
2015-10-06 23:56 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2015-10-06 23:39:43 PDT 
When data points selected as end-points for an analysis task are marked as outliers,
the dashboard doesn't show those analysis tasks on the charts.

(Furthermore, we throw an exception if my monkey-patch wasn't applied).
Comment 1 Ryosuke Niwa 2015-10-06 23:56:43 PDT 
Created attachment 262586 [details]
Fixes the bug
Comment 2 Chris Dumez 2015-10-07 09:20:08 PDT 
Comment on attachment 262586 [details]
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=262586&action=review

rs=me

> Websites/perf.webkit.org/public/v2/app.js:446
> +                return (+firstPoint.time + +secondPoint.time) / 2;

What's the purpose of the extra '+' signs?
Comment 3 Ryosuke Niwa 2015-10-07 10:54:01 PDT 
Comment on attachment 262586 [details]
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=262586&action=review

>> Websites/perf.webkit.org/public/v2/app.js:446
>> +                return (+firstPoint.time + +secondPoint.time) / 2;
> 
> What's the purpose of the extra '+' signs?

It converts Date objects to numbers.
Comment 4 WebKit Commit Bot 2015-10-07 11:38:38 PDT 
Comment on attachment 262586 [details]
Fixes the bug

Clearing flags on attachment: 262586

Committed r190676: <http://trac.webkit.org/changeset/190676>
Comment 5 WebKit Commit Bot 2015-10-07 11:38:43 PDT 
All reviewed patches have been landed.  Closing bug.