RESOLVED FIXED Bug 149870
Perf dashboard doesn't show analysis tasks anchored at outliers 
https://bugs.webkit.org/show_bug.cgi?id=149870
Summary Perf dashboard doesn't show analysis tasks anchored at outliers
Ryosuke Niwa
Reported 2015-10-06 23:39:43 PDT
When data points selected as end-points for an analysis task are marked as outliers, the dashboard doesn't show those analysis tasks on the charts. (Furthermore, we throw an exception if my monkey-patch wasn't applied).
Attachments
Fixes the bug (11.46 KB, patch)
2015-10-06 23:56 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2015-10-06 23:56:43 PDT
Created attachment 262586 [details] Fixes the bug
Chris Dumez
Comment 2 2015-10-07 09:20:08 PDT
Comment on attachment 262586 [details] Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=262586&action=review rs=me > Websites/perf.webkit.org/public/v2/app.js:446 > + return (+firstPoint.time + +secondPoint.time) / 2; What's the purpose of the extra '+' signs?
Ryosuke Niwa
Comment 3 2015-10-07 10:54:01 PDT
Comment on attachment 262586 [details] Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=262586&action=review >> Websites/perf.webkit.org/public/v2/app.js:446 >> + return (+firstPoint.time + +secondPoint.time) / 2; > > What's the purpose of the extra '+' signs? It converts Date objects to numbers.
WebKit Commit Bot
Comment 4 2015-10-07 11:38:38 PDT
Comment on attachment 262586 [details] Fixes the bug Clearing flags on attachment: 262586 Committed r190676: <http://trac.webkit.org/changeset/190676>
WebKit Commit Bot
Comment 5 2015-10-07 11:38:43 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.