Bug 149851

Summary:

WKPage needs to expose a KVO-compliant object, similar to WKWebView

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	mitz: review+

Description Anders Carlsson 2015-10-06 10:39:47 PDT

WKPage needs to expose a KVO-compliant object, similar to WKWebView

Comment 1 Anders Carlsson 2015-10-06 10:41:51 PDT

Created attachment 262522 [details]
Patch

Comment 2 mitz 2015-10-06 10:57:49 PDT

Comment on attachment 262522 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262522&action=review

> Source/WebKit2/UIProcess/API/C/mac/WKPagePrivateMac.h:36
> +WK_EXPORT id WKPageCreatePageObserver(WKPageRef page);

Perhaps this should be WKPageCreateObservableState and return an id <_WKObservablePageState>.

This function may also need to be annotated for ARC.

Comment 3 Anders Carlsson 2015-10-06 11:32:00 PDT

Created attachment 262529 [details]
Patch

Comment 4 Anders Carlsson 2015-10-06 12:12:07 PDT

Committed r190631: <http://trac.webkit.org/changeset/190631>