Bug 149842

Summary: Enable WritableStream by default
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebCore Misc.Assignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, calvaris, d, ggaren, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 149751, 215267    
Bug Blocks: 138561    
Attachments:
Description Flags
Patch none

youenn fablet
Reported 2015-10-06 07:27:30 PDT
We should implement https://streams.spec.whatwg.org/#ws-class
Attachments
Patch (1.24 KB, patch)
2020-08-26 05:34 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Xabier Rodríguez Calvar
Comment 1 2015-10-06 07:30:46 PDT
I have it ready, I will begin upstreaming step by step soon.
Domenic Denicola
Comment 2 2017-03-28 00:58:11 PDT
I noticed that Safari Tech Preview implements an earlier version of the spec. What are the plans for updating to the latest version? The spec is quite stable these days. We have been tweaking edge case behaviors over the last month (e.g. what happens if you abort() then immediately close()) and have arrived at a place we are pretty happy with. The tests are also available in web-platform-tests.
youenn fablet
Comment 3 2017-03-28 08:40:35 PDT
Hi Domenic, It would be good to update to the latest spec but I haven't been able to allocate time for it. Hopefully, I will have some time during the summer. Let me know if there is any use case where not having writable stream support is highly damageable. From what I heard from you, I guess all pipe corner cases are now ironed out, that is really good and we should also be able to refresh the ReadableStream implementation.
Domenic Denicola
Comment 4 2017-03-30 23:05:53 PDT
That's great! Yeah, we are also happy with pipeTo(). I just noticed that Safari 10.1 shipped with an older version of the writable stream spec though :-/. Is there any chance of disabling it or similar until it is updated to the latest spec?
youenn fablet
Comment 5 2020-08-26 05:34:54 PDT
Created attachment 407292 [details] Patch
EWS
Comment 6 2020-08-26 10:35:03 PDT
Committed r266172: <https://trac.webkit.org/changeset/266172> All reviewed patches have been landed. Closing bug and clearing flags on attachment 407292 [details].
Radar WebKit Bug Importer
Comment 7 2020-08-26 10:36:20 PDT
<rdar://problem/67814486>
Note You need to log in before you can comment on or make changes to this bug.