Bug 149838

Summary: Binding generator XXConstructor::finishCreation should take references as parameters
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebCore Misc.Assignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, darin
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 149849    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Resetting binding tests
none
Fixing OOPS none

youenn fablet
Reported 2015-10-06 05:08:05 PDT
It might be better to move from pointers to references in the code generated by the binding generator. This may also help aligning generated code with templates that might simplify the binding generator.
Attachments
Patch (43.26 KB, patch)
2015-10-06 05:22 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Resetting binding tests (53.86 KB, patch)
2015-10-06 12:08 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Fixing OOPS (53.86 KB, patch)
2015-10-06 12:18 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2015-10-06 05:22:33 PDT
Created attachment 262510 [details] Patch
WebKit Commit Bot
Comment 2 2015-10-06 09:38:02 PDT
Comment on attachment 262510 [details] Patch Clearing flags on attachment: 262510 Committed r190619: <http://trac.webkit.org/changeset/190619>
WebKit Commit Bot
Comment 3 2015-10-06 09:38:07 PDT
All reviewed patches have been landed. Closing bug.
WebKit Commit Bot
Comment 4 2015-10-06 10:29:52 PDT
Re-opened since this is blocked by bug 149849
youenn fablet
Comment 5 2015-10-06 12:08:03 PDT
Created attachment 262533 [details] Resetting binding tests
WebKit Commit Bot
Comment 6 2015-10-06 12:15:29 PDT
Comment on attachment 262533 [details] Resetting binding tests Rejecting attachment 262533 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 262533, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!. Full output: http://webkit-queues.webkit.org/results/251358
youenn fablet
Comment 7 2015-10-06 12:18:12 PDT
Created attachment 262535 [details] Fixing OOPS
WebKit Commit Bot
Comment 8 2015-10-06 13:14:39 PDT
Comment on attachment 262535 [details] Fixing OOPS Clearing flags on attachment: 262535 Committed r190637: <http://trac.webkit.org/changeset/190637>
WebKit Commit Bot
Comment 9 2015-10-06 13:14:45 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.