Bug 149838

Summary: Binding generator XXConstructor::finishCreation should take references as parameters
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebCore Misc.Assignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, darin
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 149849    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Resetting binding tests
none
Fixing OOPS none

Description youenn fablet 2015-10-06 05:08:05 PDT 
It might be better to move from pointers to references in the code generated by the binding generator.
This may also help aligning generated code with templates that might simplify the binding generator.
Comment 1 youenn fablet 2015-10-06 05:22:33 PDT 
Created attachment 262510 [details]
Patch
Comment 2 WebKit Commit Bot 2015-10-06 09:38:02 PDT 
Comment on attachment 262510 [details]
Patch

Clearing flags on attachment: 262510

Committed r190619: <http://trac.webkit.org/changeset/190619>
Comment 3 WebKit Commit Bot 2015-10-06 09:38:07 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 WebKit Commit Bot 2015-10-06 10:29:52 PDT 
Re-opened since this is blocked by bug 149849
Comment 5 youenn fablet 2015-10-06 12:08:03 PDT 
Created attachment 262533 [details]
Resetting binding tests
Comment 6 WebKit Commit Bot 2015-10-06 12:15:29 PDT 
Comment on attachment 262533 [details]
Resetting binding tests

Rejecting attachment 262533 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 262533, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.

Full output: http://webkit-queues.webkit.org/results/251358
Comment 7 youenn fablet 2015-10-06 12:18:12 PDT 
Created attachment 262535 [details]
Fixing OOPS
Comment 8 WebKit Commit Bot 2015-10-06 13:14:39 PDT 
Comment on attachment 262535 [details]
Fixing OOPS

Clearing flags on attachment: 262535

Committed r190637: <http://trac.webkit.org/changeset/190637>
Comment 9 WebKit Commit Bot 2015-10-06 13:14:45 PDT 
All reviewed patches have been landed.  Closing bug.