Bug 149837

Summary: Binding generator should add builtin header for JSBuiltin attributes
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebCore Misc.Assignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, cdumez, commit-queue, darin
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description youenn fablet 2015-10-06 03:17:05 PDT
Following on https://bugs.webkit.org/show_bug.cgi?id=149759, we should further refactor AddIncludesForJSBuiltinMethods, since returning 1 is no longer needed.
We should also handle JSBuiltin attributes similarly to JSBuiltin functions.
Comment 1 Xabier Rodríguez Calvar 2015-10-06 03:43:41 PDT
(In reply to comment #0)
> Following on https://bugs.webkit.org/show_bug.cgi?id=149759, we should
> further refactor AddIncludesForJSBuiltinMethods, since returning 1 is no
> longer needed.
> We should also handle JSBuiltin attributes similarly to JSBuiltin functions.

Returning 1 is needed to break the loop.
Comment 2 youenn fablet 2015-10-06 04:49:13 PDT
Created attachment 262509 [details]
Patch
Comment 3 youenn fablet 2015-10-06 04:52:20 PDT
(In reply to comment #1)
> (In reply to comment #0)
> > Following on https://bugs.webkit.org/show_bug.cgi?id=149759, we should
> > further refactor AddIncludesForJSBuiltinMethods, since returning 1 is no
> > longer needed.
> > We should also handle JSBuiltin attributes similarly to JSBuiltin functions.
> 
> Returning 1 is needed to break the loop.

Not breaking the loop has the slight benefit of being able to handle different Conditionals.
I updated TestObj.idl to show this in the binding tests.
Comment 4 Xabier Rodríguez Calvar 2015-10-06 07:25:59 PDT
(In reply to comment #3)
> (In reply to comment #1)
> > (In reply to comment #0)
> > > Following on https://bugs.webkit.org/show_bug.cgi?id=149759, we should
> > > further refactor AddIncludesForJSBuiltinMethods, since returning 1 is no
> > > longer needed.
> > > We should also handle JSBuiltin attributes similarly to JSBuiltin functions.
> > 
> > Returning 1 is needed to break the loop.
> 
> Not breaking the loop has the slight benefit of being able to handle
> different Conditionals.
> I updated TestObj.idl to show this in the binding tests.

Understood.
Comment 5 WebKit Commit Bot 2015-10-06 09:50:53 PDT
Comment on attachment 262509 [details]
Patch

Clearing flags on attachment: 262509

Committed r190620: <http://trac.webkit.org/changeset/190620>
Comment 6 WebKit Commit Bot 2015-10-06 09:50:58 PDT
All reviewed patches have been landed.  Closing bug.