Bug 149822

Summary: [iOS] REGRESSION(r190434): Media continues to play when locking screen
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Jer Noble 2015-10-05 15:48:50 PDT
[iOS] REGRESSION(r190434): Media continues to play when locking screen
Comment 1 Jer Noble 2015-10-05 16:05:05 PDT
Created attachment 262475 [details]
Patch
Comment 2 Brent Fulgham 2015-10-05 16:44:04 PDT
Comment on attachment 262475 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262475&action=review

This change looks good. It would be even better if we had a test that locking the device during playback (with and without air-play) did the right thing. Do we have such a test? If not, could you at least file a bug to remind us to create that test?

> Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm:280
> +    Vector<PlatformMediaSession*> sessions = this->sessions();

You could use auto here, but that's taste-specific.
Comment 3 WebKit Commit Bot 2015-10-05 21:14:02 PDT
Comment on attachment 262475 [details]
Patch

Clearing flags on attachment: 262475

Committed r190604: <http://trac.webkit.org/changeset/190604>
Comment 4 WebKit Commit Bot 2015-10-05 21:14:07 PDT
All reviewed patches have been landed.  Closing bug.