Summary: | Marking compositing/video/video-poster.html as flaky | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryan Haddad <ryanhaddad> | ||||||||||
Component: | Tools / Tests | Assignee: | Ryan Haddad <ryanhaddad> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | ap, commit-queue, lforschler, simon.fraser | ||||||||||
Priority: | P2 | ||||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Mac | ||||||||||||
OS: | OS X 10.11 | ||||||||||||
Attachments: |
|
Description
Ryan Haddad
2015-10-05 15:36:37 PDT
This is actually a bad bug in the underlying frameworks. Created attachment 262471 [details]
Patch
Comment on attachment 262471 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=262471&action=review > LayoutTests/ChangeLog:7 > + Unreviewed test gardening. But it is reviewed! > LayoutTests/platform/mac-elcapitan/TestExpectations:2 > +# to the Apple Mac port running El Capitan (DumpRenderTree) This is the generic Mac TestExpectations, so not just limited to DumpRenderTree. You can remove the "(DumpRenderTree)". Created attachment 262477 [details]
Patch
Patch updated with suggested changes. Thanks! Comment on attachment 262477 [details] Patch Clearing flags on attachment: 262477 Committed r190590: <http://trac.webkit.org/changeset/190590> All reviewed patches have been landed. Closing bug. Did not land expectations properly. Reopening. Created attachment 262528 [details]
Patch
Comment on attachment 262528 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=262528&action=review > LayoutTests/platform/mac/TestExpectations:1336 > +webkit.org/b/149819 [ ElCapitan+ ] compositing/video/video-poster.html [ Pass Crash ] I think that it's a debug assertion, so you also want a Debug qualifier: webkit.org/b/149819 [ Debug ElCapitan+ ] compositing/video/video-poster.html [ Pass Crash ] Created attachment 262530 [details]
Patch
Comment on attachment 262530 [details] Patch Clearing flags on attachment: 262530 Committed r190642: <http://trac.webkit.org/changeset/190642> All reviewed patches have been landed. Closing bug. |