Bug 149818

Summary:

Disable Bitcode when building for iOS device

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

Tools / Tests

Assignee:

Daniel Bates <dbates>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, ddkilzer, lforschler

Priority:

Version:

WebKit Local Build

Hardware:

iPhone / iPad

OS:

iOS 9.0

Bug Depends on:

140828

Bug Blocks:

Attachments:

Description	Flags
Patch	ap: review+

Description Daniel Bates 2015-10-05 14:58:03 PDT

Do not generate bitcode when building for iOS device. Xcode 7 generates bitcode for iOS device apps by default.

Comment 1 Daniel Bates 2015-10-05 14:59:36 PDT

With the patch for bug #140828, running build-webkit --debug --device eventually fails with the following message:

ld: -unexported_symbol and -bitcode_bundle (Xcode setting ENABLE_BITCODE=YES) cannot be used together

Comment 2 Daniel Bates 2015-10-05 15:00:26 PDT

Created attachment 262465 [details]
Patch

Comment 3 Alexey Proskuryakov 2015-10-05 15:14:10 PDT

Comment on attachment 262465 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262465&action=review

> Tools/ChangeLog:9
> +        Xcode 7 generates bitcode for iOS device apps by default. For now, do not generate bitcode
> +        when building for iOS device.

Why is it "for now"? Not sure why we'd need that for a system framework.

Comment 4 Daniel Bates 2015-10-05 15:26:59 PDT

(In reply to comment #3)
> Comment on attachment 262465 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=262465&action=review
> 
> > Tools/ChangeLog:9
> > +        Xcode 7 generates bitcode for iOS device apps by default. For now, do not generate bitcode
> > +        when building for iOS device.
> 
> Why is it "for now"? Not sure why we'd need that for a system framework.

We do not need it. Will remove the phrase "For now".

Comment 5 Daniel Bates 2015-10-05 15:36:25 PDT

Committed r190584: <http://trac.webkit.org/changeset/190584>