Bug 149815

Summary: Fix run-javascriptcore-tests/run-jsc-stress-tests to work with rootless, add a --quick option and deprecate the Mozilla driver.
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, fpizlo, ggaren, lforschler, ossy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch fpizlo: review+

Keith Miller
Reported 2015-10-05 11:54:53 PDT
Fix run-javascriptcore-tests/run-jsc-stress-tests to work with rootless, add a --quick option and deprecate the Mozilla driver.
Attachments
Patch (20.42 KB, patch)
2015-10-05 16:21 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch (20.76 KB, patch)
2015-10-06 10:50 PDT, Keith Miller 		fpizlo: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2015-10-05 16:21:55 PDT
Created attachment 262478 [details] Patch
Alexey Proskuryakov
Comment 2 2015-10-05 19:03:55 PDT
Comment on attachment 262478 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=262478&action=review > Tools/ChangeLog:11 > + Finally, I removed the calls to the mozilla jsDriver.pl it appears unused. I do not think that it is unused. In fact, this code path is where we see the crash on llint cloop bot.
Keith Miller
Comment 3 2015-10-06 09:43:27 PDT
Comment on attachment 262478 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=262478&action=review >> Tools/ChangeLog:11 >> + Finally, I removed the calls to the mozilla jsDriver.pl it appears unused. > > I do not think that it is unused. In fact, this code path is where we see the crash on llint cloop bot. I guess I phrased that poorly. I had a discussion offline with Filip and Geoff and the consensus was that we should only use one test driver. Currently, `run-javascript-core tests --jsc-stress` will run all the mozilla tests so keeping the mozilla driver is just more maintenance. I'll clarify the ChangeLog.
Keith Miller
Comment 4 2015-10-06 10:50:53 PDT
Created attachment 262525 [details] Patch
Keith Miller
Comment 5 2015-10-06 11:40:03 PDT
*** Bug 149675 has been marked as a duplicate of this bug. ***
Keith Miller
Comment 6 2015-10-06 11:41:52 PDT
rdar://problem/22918927
Radar WebKit Bug Importer
Comment 7 2015-10-06 11:42:31 PDT
<rdar://problem/22994825>
Keith Miller
Comment 8 2015-10-06 11:45:32 PDT
Committed r190630: <http://trac.webkit.org/changeset/190630>
Note You need to log in before you can comment on or make changes to this bug.