| Summary: | Fix run-javascriptcore-tests/run-jsc-stress-tests to work with rootless, add a --quick option and deprecate the Mozilla driver. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Keith Miller <keith_miller> | ||||||
| Component: | New Bugs | Assignee: | Keith Miller <keith_miller> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | ap, fpizlo, ggaren, lforschler, ossy, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Keith Miller
2015-10-05 11:54:53 PDT
Created attachment 262478 [details]
Patch
Comment on attachment 262478 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=262478&action=review > Tools/ChangeLog:11 > + Finally, I removed the calls to the mozilla jsDriver.pl it appears unused. I do not think that it is unused. In fact, this code path is where we see the crash on llint cloop bot. Comment on attachment 262478 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=262478&action=review >> Tools/ChangeLog:11 >> + Finally, I removed the calls to the mozilla jsDriver.pl it appears unused. > > I do not think that it is unused. In fact, this code path is where we see the crash on llint cloop bot. I guess I phrased that poorly. I had a discussion offline with Filip and Geoff and the consensus was that we should only use one test driver. Currently, `run-javascript-core tests --jsc-stress` will run all the mozilla tests so keeping the mozilla driver is just more maintenance. I'll clarify the ChangeLog. Created attachment 262525 [details]
Patch
*** Bug 149675 has been marked as a duplicate of this bug. *** Committed r190630: <http://trac.webkit.org/changeset/190630> |