Bug 149812

Summary: Support webkit-test-runner key-value pairs in http tests
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, ap, buildbot, commit-queue, glenn, graouts, mmaxfield, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews102 for mac-mavericks
none
Patch
none
Archive of layout-test-results from ews102 for mac-elcapitan
none
Archive of layout-test-results from ews112 for mac-elcapitan
none
Patch
none
Patch none

Alex Christensen
Reported 2015-10-05 11:12:47 PDT
Support webkit-test-runner key-value pairs in http tests
Attachments
Patch (10.68 KB, patch)
2015-10-05 11:22 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews102 for mac-mavericks (734.93 KB, application/zip)
2015-10-05 11:54 PDT, Build Bot 		no flags
Details
Patch (6.15 KB, patch)
2017-01-06 01:45 PST, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews102 for mac-elcapitan (789.65 KB, application/zip)
2017-01-06 02:33 PST, Build Bot 		no flags
Details
Archive of layout-test-results from ews112 for mac-elcapitan (935.17 KB, application/zip)
2017-01-06 02:42 PST, Build Bot 		no flags
Details
Patch (6.91 KB, patch)
2017-01-06 02:45 PST, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Patch (7.20 KB, patch)
2017-01-06 05:53 PST, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2015-10-05 11:22:22 PDT
Created attachment 262449 [details] Patch
Build Bot
Comment 2 2015-10-05 11:54:30 PDT
Comment on attachment 262449 [details] Patch Attachment 262449 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/247314 Number of test failures exceeded the failure limit.
Build Bot
Comment 3 2015-10-05 11:54:33 PDT
Created attachment 262452 [details] Archive of layout-test-results from ews102 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-mavericks Platform: Mac OS X 10.9.5
Alexey Proskuryakov
Comment 4 2015-10-05 19:07:13 PDT
Comment on attachment 262449 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=262449&action=review > Tools/ChangeLog:9 > + But with http tests, we do not want to send a request to the local server to get this metadata so we do not This sounds very familiar, don't we already have a code path that does the same?
Alex Christensen
Comment 5 2015-10-05 19:18:02 PDT
(In reply to comment #4) > Comment on attachment 262449 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=262449&action=review > > > Tools/ChangeLog:9 > > + But with http tests, we do not want to send a request to the local server to get this metadata so we do not > > This sounds very familiar, don't we already have a code path that does the > same? I was not aware of one. The only way I'm aware of is getting a command line parameter from python, but if there is another way I'd love to hear it.
Alexey Proskuryakov
Comment 6 2015-10-06 08:58:20 PDT
Anders or Myles would know for sure.
Myles C. Maxfield
Comment 7 2015-10-06 13:19:01 PDT
(In reply to comment #6) > Anders or Myles would know for sure. I am also not aware of one.
Myles C. Maxfield
Comment 8 2016-10-03 22:50:05 PDT
I think this is a good thing. If you got it working, I would r+ it.
Antoine Quint
Comment 9 2017-01-05 11:31:51 PST
*** Bug 166331 has been marked as a duplicate of this bug. ***
Antoine Quint
Comment 10 2017-01-05 11:32:35 PST
<rdar://problem/29772341>
Antoine Quint
Comment 11 2017-01-06 01:45:25 PST
Created attachment 298184 [details] Patch
Build Bot
Comment 12 2017-01-06 02:33:18 PST
Comment on attachment 298184 [details] Patch Attachment 298184 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2842749 Number of test failures exceeded the failure limit.
Build Bot
Comment 13 2017-01-06 02:33:22 PST
Created attachment 298186 [details] Archive of layout-test-results from ews102 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Build Bot
Comment 14 2017-01-06 02:42:32 PST
Comment on attachment 298184 [details] Patch Attachment 298184 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/2842754 Number of test failures exceeded the failure limit.
Build Bot
Comment 15 2017-01-06 02:42:36 PST
Created attachment 298188 [details] Archive of layout-test-results from ews112 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Antoine Quint
Comment 16 2017-01-06 02:45:13 PST
Created attachment 298189 [details] Patch
Antoine Quint
Comment 17 2017-01-06 05:53:32 PST
Created attachment 298198 [details] Patch
WebKit Commit Bot
Comment 18 2017-01-06 10:51:16 PST
Comment on attachment 298198 [details] Patch Clearing flags on attachment: 298198 Committed r210446: <http://trac.webkit.org/changeset/210446>
WebKit Commit Bot
Comment 19 2017-01-06 10:51:22 PST
All reviewed patches have been landed. Closing bug.
Antoine Quint
Comment 20 2017-01-09 04:17:53 PST
Followup work for WK1 is at https://bugs.webkit.org/show_bug.cgi?id=166837.
Note You need to log in before you can comment on or make changes to this bug.