Bug 149810

Summary: [css-grid] Percentages of indefinite sizes to be resolved as auto
Product: WebKit Reporter: Sergio Villar Senin <svillar>
Component: New BugsAssignee: Sergio Villar Senin <svillar>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, esprehn+autocc, glenn, jfernandez, kondapallykalyan, rego, svillar
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing
none
Patch for landing
none
Patch for landing none

Description Sergio Villar Senin 2015-10-05 09:48:42 PDT
[css-grid] Percentages of indefinite sizes to be resolved as auto
Comment 1 Sergio Villar Senin 2015-10-06 00:29:04 PDT
Created attachment 262506 [details]
Patch
Comment 2 Darin Adler 2015-10-06 07:23:29 PDT
Comment on attachment 262506 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262506&action=review

> Source/WebCore/rendering/RenderGrid.cpp:563
> +        static NeverDestroyed<GridLength> autoLength((Length(Auto)));

Why the global variable?
Comment 3 Sergio Villar Senin 2015-10-07 01:35:32 PDT
Comment on attachment 262506 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262506&action=review

>> Source/WebCore/rendering/RenderGrid.cpp:563
>> +        static NeverDestroyed<GridLength> autoLength((Length(Auto)));
> 
> Why the global variable?

No special reason, just to avoid creating it over and over again, but not strong feelings about it.
Comment 4 Sergio Villar Senin 2015-10-07 03:21:25 PDT
Created attachment 262591 [details]
Patch

Removed the global variable and the extra include
Comment 5 Sergio Villar Senin 2015-10-08 05:24:37 PDT
Created attachment 262689 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2015-10-08 05:26:25 PDT
Comment on attachment 262689 [details]
Patch for landing

Rejecting attachment 262689 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 262689, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.

Full output: http://webkit-queues.webkit.org/results/257292
Comment 7 Sergio Villar Senin 2015-10-08 05:34:02 PDT
Created attachment 262690 [details]
Patch for landing
Comment 8 Sergio Villar Senin 2015-10-08 05:35:25 PDT
Created attachment 262691 [details]
Patch for landing
Comment 9 WebKit Commit Bot 2015-10-08 06:29:26 PDT
Comment on attachment 262691 [details]
Patch for landing

Clearing flags on attachment: 262691

Committed r190721: <http://trac.webkit.org/changeset/190721>
Comment 10 WebKit Commit Bot 2015-10-08 06:29:30 PDT
All reviewed patches have been landed.  Closing bug.