Bug 149810

Summary: [css-grid] Percentages of indefinite sizes to be resolved as auto
Product: WebKit Reporter: Sergio Villar Senin <svillar>
Component: New BugsAssignee: Sergio Villar Senin <svillar>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, esprehn+autocc, glenn, jfernandez, kondapallykalyan, rego, svillar
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing
none
Patch for landing
none
Patch for landing none

Sergio Villar Senin
Reported 2015-10-05 09:48:42 PDT
[css-grid] Percentages of indefinite sizes to be resolved as auto
Attachments
Patch (2.38 KB, patch)
2015-10-06 00:29 PDT, Sergio Villar Senin 		no flags
DetailsFormatted DiffDiff
Patch (2.43 KB, patch)
2015-10-07 03:21 PDT, Sergio Villar Senin 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.41 KB, patch)
2015-10-08 05:24 PDT, Sergio Villar Senin 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.41 KB, patch)
2015-10-08 05:34 PDT, Sergio Villar Senin 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.41 KB, patch)
2015-10-08 05:35 PDT, Sergio Villar Senin 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Sergio Villar Senin
Comment 1 2015-10-06 00:29:04 PDT
Created attachment 262506 [details] Patch
Darin Adler
Comment 2 2015-10-06 07:23:29 PDT
Comment on attachment 262506 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=262506&action=review > Source/WebCore/rendering/RenderGrid.cpp:563 > + static NeverDestroyed<GridLength> autoLength((Length(Auto))); Why the global variable?
Sergio Villar Senin
Comment 3 2015-10-07 01:35:32 PDT
Comment on attachment 262506 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=262506&action=review >> Source/WebCore/rendering/RenderGrid.cpp:563 >> + static NeverDestroyed<GridLength> autoLength((Length(Auto))); > > Why the global variable? No special reason, just to avoid creating it over and over again, but not strong feelings about it.
Sergio Villar Senin
Comment 4 2015-10-07 03:21:25 PDT
Created attachment 262591 [details] Patch Removed the global variable and the extra include
Sergio Villar Senin
Comment 5 2015-10-08 05:24:37 PDT
Created attachment 262689 [details] Patch for landing
WebKit Commit Bot
Comment 6 2015-10-08 05:26:25 PDT
Comment on attachment 262689 [details] Patch for landing Rejecting attachment 262689 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 262689, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!. Full output: http://webkit-queues.webkit.org/results/257292
Sergio Villar Senin
Comment 7 2015-10-08 05:34:02 PDT
Created attachment 262690 [details] Patch for landing
Sergio Villar Senin
Comment 8 2015-10-08 05:35:25 PDT
Created attachment 262691 [details] Patch for landing
WebKit Commit Bot
Comment 9 2015-10-08 06:29:26 PDT
Comment on attachment 262691 [details] Patch for landing Clearing flags on attachment: 262691 Committed r190721: <http://trac.webkit.org/changeset/190721>
WebKit Commit Bot
Comment 10 2015-10-08 06:29:30 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.