Bug 149800 – [css-grid] Implement grid gutters

• Component: New Bugs
• Status: RESOLVED FIXED

[Sergio Villar Senin]

[css-grid] Implement grid gutters

[Sergio Villar Senin]

Citing the specs

    "These properties specify the gutters between grid rows and grid columns, respectively. The effect is as though the affected grid lines acquired width: the grid track between two grid lines is the space between the gutters that represent them."

[Sergio Villar Senin]

Created attachment 262421 [details]
Patch

[Sergio Villar Senin]

Created attachment 262437 [details]
Patch

removed normal as a valid keyword

[Darin Adler]

Comment on attachment 262437 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262437&action=review

> Source/WebCore/rendering/style/StyleGridData.h:51
>          // FIXME: comparing two hashes doesn't look great for performance. Something to keep in mind going forward.

I don’t understand this comment. Where is the code comparing two hashes?

> Source/WebCore/rendering/style/StyleGridData.h:58
> +        return m_gridColumns == o.m_gridColumns && m_gridRows == o.m_gridRows
> +        && m_gridAutoFlow == o.m_gridAutoFlow && m_gridAutoRows == o.m_gridAutoRows && m_gridAutoColumns == o.m_gridAutoColumns
> +        && m_namedGridColumnLines == o.m_namedGridColumnLines && m_namedGridRowLines == o.m_namedGridRowLines
> +        && m_namedGridArea == o.m_namedGridArea && m_namedGridArea == o.m_namedGridArea
> +        && m_namedGridAreaRowCount == o.m_namedGridAreaRowCount && m_namedGridAreaColumnCount == o.m_namedGridAreaColumnCount
> +        && m_orderedNamedGridRowLines == o.m_orderedNamedGridRowLines && m_orderedNamedGridColumnLines == o.m_orderedNamedGridColumnLines
> +        && m_gridColumnGap == o.m_gridColumnGap && m_gridRowGap == o.m_gridRowGap;

WebKit coding style would have the && indented by four spaces on subsequent lines.

[Sergio Villar Senin]

Comment on attachment 262437 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262437&action=review

>> Source/WebCore/rendering/style/StyleGridData.h:51
>>          // FIXME: comparing two hashes doesn't look great for performance. Something to keep in mind going forward.
> 
> I don’t understand this comment. Where is the code comparing two hashes?

Some of those structures are hashmaps.

>> Source/WebCore/rendering/style/StyleGridData.h:58
>> +        && m_gridColumnGap == o.m_gridColumnGap && m_gridRowGap == o.m_gridRowGap;
> 
> WebKit coding style would have the && indented by four spaces on subsequent lines.

Not sure why it has this weird indentation, I'll fix it.

[Sergio Villar Senin]

Committed r190663: <http://trac.webkit.org/changeset/190663>