|Summary:||CodeBlock.h shouldn't be included from everywhere|
|Product:||WebKit||Reporter:||Filip Pizlo <fpizlo>|
|Component:||New Bugs||Assignee:||Filip Pizlo <fpizlo>|
|Severity:||Normal||CC:||barraclough, benjamin, commit-queue, ggaren, mark.lam, mhahnenb, msaboff, nrotem, oliver, sam, sbarati, simon.fraser|
|Version:||WebKit Nightly Build|
Description Filip Pizlo 2015-10-03 15:59:50 PDT
CodeBlock.h shouldn't be included from everywhere
Comment 2 Filip Pizlo 2015-10-04 12:35:04 PDT
Comment on attachment 262383 [details] Patch Actually, I will land myself. I'll also try to make this more robust by making CodeBlock.h into a Project header so WebCore cannot include it.
Comment 3 Filip Pizlo 2015-10-04 15:40:22 PDT
Comment on attachment 262383 [details] Patch OK, I'll let commit-queue land it. I was trying to remove a bunch of headers, including CodeBlock.h, from the Private headers list. But it turns out that there is some test support code in WebCore that includes CodeBlock.h directly. Removing that dependency didn't seem like an easy task. So, CodeBlock.h can still be included from anywhere, but at least it's no longer included from everywhere.
Comment 4 WebKit Commit Bot 2015-10-04 16:26:14 PDT
Comment on attachment 262383 [details] Patch Clearing flags on attachment: 262383 Committed r190555: <http://trac.webkit.org/changeset/190555>
Comment 5 WebKit Commit Bot 2015-10-04 16:26:18 PDT
All reviewed patches have been landed. Closing bug.