Bug 149785

Summary: CodeBlock.h shouldn't be included from everywhere
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: New BugsAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, benjamin, commit-queue, ggaren, mark.lam, mhahnenb, msaboff, nrotem, oliver, saam, sam, simon.fraser
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=153810
Attachments:
Description Flags
Patch none

Filip Pizlo
Reported 2015-10-03 15:59:50 PDT
CodeBlock.h shouldn't be included from everywhere
Attachments
Patch (15.34 KB, patch)
2015-10-03 16:00 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2015-10-03 16:00:29 PDT
Created attachment 262383 [details] Patch
Filip Pizlo
Comment 2 2015-10-04 12:35:04 PDT
Comment on attachment 262383 [details] Patch Actually, I will land myself. I'll also try to make this more robust by making CodeBlock.h into a Project header so WebCore cannot include it.
Filip Pizlo
Comment 3 2015-10-04 15:40:22 PDT
Comment on attachment 262383 [details] Patch OK, I'll let commit-queue land it. I was trying to remove a bunch of headers, including CodeBlock.h, from the Private headers list. But it turns out that there is some test support code in WebCore that includes CodeBlock.h directly. Removing that dependency didn't seem like an easy task. So, CodeBlock.h can still be included from anywhere, but at least it's no longer included from everywhere.
WebKit Commit Bot
Comment 4 2015-10-04 16:26:14 PDT
Comment on attachment 262383 [details] Patch Clearing flags on attachment: 262383 Committed r190555: <http://trac.webkit.org/changeset/190555>
WebKit Commit Bot
Comment 5 2015-10-04 16:26:18 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.