Bug 149777 – Test font-variant-* and font-feature-settings with mocked preinstalled fonts

• Component: Text
• Status: RESOLVED FIXED

[Myles C. Maxfield]

We should use the same mechanism that we use for WebKitWeightWatcher to mock installing a font for tests. Then, we can test font features on preinstalled fonts.

[Radar WebKit Bug Importer]

<rdar://problem/22959758>

[Myles C. Maxfield]

Created attachment 262845 [details]
Patch

[Build Bot]

Comment on attachment 262845 [details]
Patch

Attachment 262845 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/266740

New failing tests:
css3/font-variant-all.html

[Build Bot]

Created attachment 262847 [details]
Archive of layout-test-results from ews102 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-mavericks  Platform: Mac OS X 10.9.5

[Build Bot]

Comment on attachment 262845 [details]
Patch

Attachment 262845 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/266746

New failing tests:
css3/font-variant-all.html

[Build Bot]

Created attachment 262848 [details]
Archive of layout-test-results from ews104 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5

[Myles C. Maxfield]

I need to update TestExpectations.

[Myles C. Maxfield]

Created attachment 262851 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 262851 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262851&action=review

> Tools/FontWithFeatures/FontWithFeatures/main.cpp:129
> -    std::ofstream outputFile("/Volumes/Data/home/mmaxfield/tmp/output.ttf", std::ios::out | std::ios::binary);
> +    std::ofstream outputFile("/Volumes/Data/home/mmaxfield/src/WebKit/OpenSource/LayoutTests/css3/resources/FontWithFeatures.ttf", std::ios::out | std::ios::binary);

It's wrong to have a hard-coded path that only works on your machine here.

[Myles C. Maxfield]

Committed r190848: <http://trac.webkit.org/changeset/190848>

[Daniel Bates]

(In reply to comment #10)
> Committed r190848: <http://trac.webkit.org/changeset/190848>

This changes prevents us from running tests as iOS DumpRenderTree exits with error "Failed to create CGFontRef for the FontWithFeaturesTTF font":

<https://build.webkit.org/results/Apple%20iOS%209%20Simulator%20Release%20WK1%20(Tests)/r191029%20(324)/results.html>

[Myles C. Maxfield]

(In reply to comment #11)
> (In reply to comment #10)
> > Committed r190848: <http://trac.webkit.org/changeset/190848>
> 
> This changes prevents us from running tests as iOS DumpRenderTree exits with
> error "Failed to create CGFontRef for the FontWithFeaturesTTF font":
> 
> <https://build.webkit.org/results/
> Apple%20iOS%209%20Simulator%20Release%20WK1%20(Tests)/r191029%20(324)/
> results.html>

http://trac.webkit.org/changeset/191032 fixes this.