Bug 149771

Summary:

font-variant-* properties in @font-face declarations should be honored

Product:

WebKit

Reporter:

Myles C. Maxfield <mmaxfield>

Component:

Text

Assignee:

Myles C. Maxfield <mmaxfield>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, dino, jonlee, koivisto, rniwa, ryanhaddad, simon.fraser, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

151185

Bug Blocks:

149779

Attachments:

Description	Flags
Patch	none
Patch	simon.fraser: review+
Patch for committing	buildbot: commit-queue-
Archive of layout-test-results from ews100 for mac-mavericks	none
Archive of layout-test-results from ews104 for mac-mavericks-wk2	none
Archive of layout-test-results from ews114 for mac-yosemite	none
Patch for committing	none

Myles C. Maxfield

Reported 2015-10-02 16:53:11 PDT

Currently, they are ignored.

Attachments
Patch (79.45 KB, patch) 2015-11-01 21:56 PST, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (81.37 KB, patch) 2015-11-02 01:51 PST, Myles C. Maxfield	simon.fraser: review+	Details Formatted Diff Diff
Patch for committing (94.57 KB, patch) 2015-11-03 01:00 PST, Myles C. Maxfield	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews100 for mac-mavericks (467.56 KB, application/zip) 2015-11-03 01:44 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews104 for mac-mavericks-wk2 (433.25 KB, application/zip) 2015-11-03 01:46 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews114 for mac-yosemite (421.31 KB, application/zip) 2015-11-03 03:34 PST, Build Bot	no flags	Details
Patch for committing (94.20 KB, patch) 2015-11-03 11:01 PST, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2015-10-02 17:17:08 PDT

<rdar://problem/22959887>

Myles C. Maxfield

Comment 2 2015-11-01 21:56:03 PST

Created attachment 264552 [details] Patch

Myles C. Maxfield

Comment 3 2015-11-01 21:57:53 PST

Comment on attachment 264552 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=264552&action=review > Source/WebCore/ChangeLog:21 > + Tests: css3/font-feature-settings-font-face-rendering.html I need a test to make sure these new values can be correctly overriden. > Source/WebCore/platform/graphics/FontCascade.cpp:598 > + // FIXME: @font-face features should also cause this to be complex. Link to https://bugs.webkit.org/show_bug.cgi?id=150791

Myles C. Maxfield

Comment 4 2015-11-01 21:58:37 PST

Comment on attachment 264552 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=264552&action=review > LayoutTests/css3/font-feature-settings-font-face-rendering.html:1 > +<!DOCTYPE html> This test might be flakey.

Myles C. Maxfield

Comment 5 2015-11-02 01:51:06 PST

Created attachment 264568 [details] Patch

Myles C. Maxfield

Comment 6 2015-11-03 00:33:31 PST

Comment on attachment 264568 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=264568&action=review > Source/WebCore/css/CSSFontFace.h:130 > + FontVariantSettings m_variantSettings; Uninitialized.

Myles C. Maxfield

Comment 7 2015-11-03 01:00:41 PST

Created attachment 264671 [details] Patch for committing

Build Bot

Comment 8 2015-11-03 01:44:08 PST

Comment on attachment 264671 [details] Patch for committing Attachment 264671 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/376063 Number of test failures exceeded the failure limit.

Build Bot

Comment 9 2015-11-03 01:44:11 PST

Created attachment 264673 [details] Archive of layout-test-results from ews100 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-mavericks Platform: Mac OS X 10.9.5

Build Bot

Comment 10 2015-11-03 01:46:49 PST

Comment on attachment 264671 [details] Patch for committing Attachment 264671 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/376069 Number of test failures exceeded the failure limit.

Build Bot

Comment 11 2015-11-03 01:46:52 PST

Created attachment 264675 [details] Archive of layout-test-results from ews104 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5

Build Bot

Comment 12 2015-11-03 03:34:02 PST

Comment on attachment 264671 [details] Patch for committing Attachment 264671 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/376444 Number of test failures exceeded the failure limit.

Build Bot

Comment 13 2015-11-03 03:34:06 PST

Created attachment 264684 [details] Archive of layout-test-results from ews114 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-yosemite Platform: Mac OS X 10.10.5

Myles C. Maxfield

Comment 14 2015-11-03 10:41:08 PST

Comment on attachment 264671 [details] Patch for committing View in context: https://bugs.webkit.org/attachment.cgi?id=264671&action=review > Source/WebCore/platform/graphics/FontCascade.cpp:-94 > -FontCascade::CodePath FontCascade::s_codePath = Auto; Whoops.

Myles C. Maxfield

Comment 15 2015-11-03 11:01:38 PST

Created attachment 264697 [details] Patch for committing

WebKit Commit Bot

Comment 16 2015-11-03 12:32:27 PST

Comment on attachment 264697 [details] Patch for committing Clearing flags on attachment: 264697 Committed r191968: <http://trac.webkit.org/changeset/191968>

Ryan Haddad

Comment 17 2015-11-03 15:38:37 PST

Skipped these tests on win with r191986.

Note You need to log in before you can comment on or make changes to this bug.