| Summary: | font-variant-* properties in @font-face declarations should be honored | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> | ||||||||||||||||
| Component: | Text | Assignee: | Myles C. Maxfield <mmaxfield> | ||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||
| Severity: | Normal | CC: | buildbot, commit-queue, dino, jonlee, koivisto, rniwa, ryanhaddad, simon.fraser, thorton, webkit-bug-importer | ||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||
| Bug Depends on: | 151185 | ||||||||||||||||||
| Bug Blocks: | 149779 | ||||||||||||||||||
| Attachments: |
|
||||||||||||||||||
|
Description
Myles C. Maxfield
2015-10-02 16:53:11 PDT
Created attachment 264552 [details]
Patch
Comment on attachment 264552 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=264552&action=review > Source/WebCore/ChangeLog:21 > + Tests: css3/font-feature-settings-font-face-rendering.html I need a test to make sure these new values can be correctly overriden. > Source/WebCore/platform/graphics/FontCascade.cpp:598 > + // FIXME: @font-face features should also cause this to be complex. Link to https://bugs.webkit.org/show_bug.cgi?id=150791 Comment on attachment 264552 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=264552&action=review > LayoutTests/css3/font-feature-settings-font-face-rendering.html:1 > +<!DOCTYPE html> This test might be flakey. Created attachment 264568 [details]
Patch
Comment on attachment 264568 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=264568&action=review > Source/WebCore/css/CSSFontFace.h:130 > + FontVariantSettings m_variantSettings; Uninitialized. Created attachment 264671 [details]
Patch for committing
Comment on attachment 264671 [details] Patch for committing Attachment 264671 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/376063 Number of test failures exceeded the failure limit. Created attachment 264673 [details]
Archive of layout-test-results from ews100 for mac-mavericks
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100 Port: mac-mavericks Platform: Mac OS X 10.9.5
Comment on attachment 264671 [details] Patch for committing Attachment 264671 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/376069 Number of test failures exceeded the failure limit. Created attachment 264675 [details]
Archive of layout-test-results from ews104 for mac-mavericks-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Comment on attachment 264671 [details] Patch for committing Attachment 264671 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/376444 Number of test failures exceeded the failure limit. Created attachment 264684 [details]
Archive of layout-test-results from ews114 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 264671 [details] Patch for committing View in context: https://bugs.webkit.org/attachment.cgi?id=264671&action=review > Source/WebCore/platform/graphics/FontCascade.cpp:-94 > -FontCascade::CodePath FontCascade::s_codePath = Auto; Whoops. Created attachment 264697 [details]
Patch for committing
Comment on attachment 264697 [details] Patch for committing Clearing flags on attachment: 264697 Committed r191968: <http://trac.webkit.org/changeset/191968> Skipped these tests on win with r191986. |