Bug 149757

Summary: Provide "--no-ninja" option to avoid using Ninja
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: Tools / TestsAssignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, commit-queue, dbates, lforschler
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch achristensen: review+

Brent Fulgham
Reported 2015-10-02 11:08:45 PDT
Now that we are using CMake, it's great to be able to use Ninja to do my daily builds. However, I sometimes need to regenerate a Visual Studio solution so that I can more easily navigate and edit the files in the solution. Unfortunately, as soon as you install Ninja you are locked into that generator for building. We need a "--no-ninja" argument so we can switch back and forth as needed.
Attachments
Patch (1.60 KB, patch)
2015-10-02 11:27 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch (1.62 KB, patch)
2015-10-02 12:56 PDT, Brent Fulgham 		achristensen: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2015-10-02 11:27:59 PDT
Created attachment 262343 [details] Patch
Alex Christensen
Comment 2 2015-10-02 12:17:28 PDT
Comment on attachment 262343 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=262343&action=review > Tools/Scripts/webkitdirs.pm:1817 > + return if ($shouldNotUseNinja); I think this will return the opposite of what you intend.
Brent Fulgham
Comment 3 2015-10-02 12:56:05 PDT
Created attachment 262347 [details] Patch
Brent Fulgham
Comment 4 2015-10-02 14:44:34 PDT
Committed r190524: <http://trac.webkit.org/changeset/190524>
Note You need to log in before you can comment on or make changes to this bug.