Bug 149729

Summary: Remove unnecessary SpecialFastCaseProfiles.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, fpizlo, ggaren, keith_miller, msaboff, saam, ysuzuki
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 149600    
Attachments:
Description Flags
the fix. saam: review+

Mark Lam
Reported 2015-10-01 15:38:35 PDT
The current baseline code creates special fast case profiles records for bytecodes that don't need them. This was done to keep the DFG from crashing when it searches for such a profile and don't find one. Instead, we should fix the code to check for the existence of the profile before dereferencing it to get a count.
Attachments
the fix. (6.44 KB, patch)
2015-10-01 15:45 PDT, Mark Lam 		saam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2015-10-01 15:45:54 PDT
Created attachment 262293 [details] the fix.
Saam Barati
Comment 2 2015-10-01 15:59:16 PDT
Comment on attachment 262293 [details] the fix. r=me
Mark Lam
Comment 3 2015-10-01 16:22:38 PDT
Thanks. Landed in r190435: <http://trac.webkit.org/r190435>.
Note You need to log in before you can comment on or make changes to this bug.