Bug 149710

Summary: [GTK] Websites with invalid auth header keep loading forever
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, commit-queue, gustavo, mcatanzaro, mrobinson
Priority: P2 Keywords: Gtk
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Fix coding style mrobinson: review+

Carlos Garcia Campos
Reported 2015-10-01 09:38:13 PDT
We don't correctly handle a null realm from the server when retrieving and storing credentials from libsecret. First secret_attributes_build() fails because we pass a null domain, and we pass null attributes to secret_service_search() that returns early on a g_return macro and the callback is never called so the load doesn't continue after the auth challenge. You can try with https://manga.madokami.com/login
Attachments
Patch (9.78 KB, patch)
2015-10-01 09:52 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Fix coding style (9.78 KB, patch)
2015-10-01 09:58 PDT, Carlos Garcia Campos 		mrobinson: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2015-10-01 09:52:38 PDT
Created attachment 262265 [details] Patch
WebKit Commit Bot
Comment 2 2015-10-01 09:54:58 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
WebKit Commit Bot
Comment 3 2015-10-01 09:55:05 PDT
Attachment 262265 [details] did not pass style-queue: ERROR: Source/WebCore/platform/network/gtk/CredentialBackingStore.cpp:52: Declaration has space between type name and * in const char *realm [whitespace/declaration] [3] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Carlos Garcia Campos
Comment 4 2015-10-01 09:58:33 PDT
Created attachment 262267 [details] Fix coding style
Carlos Garcia Campos
Comment 5 2015-10-01 10:19:04 PDT
Committed r190413: <http://trac.webkit.org/changeset/190413>
Note You need to log in before you can comment on or make changes to this bug.