Bug 149662 – Use modern for-loops in WebCore/html.

• Component: WebKit Misc.
• Status: RESOLVED FIXED

[Hunseop Jeong]

Refactor the for-loops using the ranged-for loops and auto keyword in WebCore/html.

[Hunseop Jeong]

Created attachment 262235 [details]
Patch

[Darin Adler]

Comment on attachment 262235 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262235&action=review

> Source/WebCore/html/FormController.cpp:270
> +        const FormElementKey& key = element.key;
>          if (!equal(key.type(), "file", 4))
>              continue;

Doesn’t seem to be helpful to put the key into a local variable here.

[Hunseop Jeong]

Created attachment 262320 [details]
Patch

[Hunseop Jeong]

(In reply to comment #2)
> Comment on attachment 262235 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=262235&action=review
> 
> > Source/WebCore/html/FormController.cpp:270
> > +        const FormElementKey& key = element.key;
> >          if (!equal(key.type(), "file", 4))
> >              continue;
> 
> Doesn’t seem to be helpful to put the key into a local variable here.

You are right. I removed the local variable.

[Hunseop Jeong]

Darin, ping?

Could you give me the cq+?

[WebKit Commit Bot]

Comment on attachment 262320 [details]
Patch

Clearing flags on attachment: 262320

Committed r190613: <http://trac.webkit.org/changeset/190613>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.