| Summary: | Make WebKit for iOS Simulator build with the public iOS 9 SDK | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Daniel Bates <dbates> | ||||
| Component: | Tools / Tests | Assignee: | Daniel Bates <dbates> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aestes, ap, commit-queue, ddkilzer, dean_johnson, eric.carlson, jeremyj-wk, jer.noble, lforschler, mitz, thorton | ||||
| Priority: | P2 | ||||||
| Version: | WebKit Local Build | ||||||
| Hardware: | iPhone / iPad | ||||||
| OS: | iOS 9.0 | ||||||
| Attachments: |
|
||||||
|
Description
Daniel Bates
2015-09-29 17:17:02 PDT
Created attachment 262123 [details]
Patch
Attachment 262123 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/spi/cocoa/PthreadSPI.h:33: pthread_set_fixedpriority_self is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
Total errors found: 1 in 11 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 262123 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=262123&action=review > Source/WebCore/ChangeLog:12 > + * platform/spi/cocoa/PthreadSPI.h: Added. The uppercase P is odd, given that the header is pthread.h > Source/WebCore/platform/spi/cocoa/AVKitSPI.h:77 > +#if __IPHONE_OS_VERSION_MIN_REQUIRED < 90000 Is this already inside PLATFORM(IOS)? > Source/WebCore/platform/spi/cocoa/AVKitSPI.h:104 > +#if __IPHONE_OS_VERSION_MIN_REQUIRED < 90000 Ditto. > Source/WebKit2/Platform/spi/ios/SafariServicesSPI.h:46 > +@interface SFSafariViewController : UIViewController Isn't SFSafariViewController public? (In reply to comment #3) > Comment on attachment 262123 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=262123&action=review > > > Source/WebCore/ChangeLog:12 > > + * platform/spi/cocoa/PthreadSPI.h: Added. > > The uppercase P is odd, given that the header is pthread.h > Will rename file to pthreadSPI.h. > > Source/WebCore/platform/spi/cocoa/AVKitSPI.h:77 > > +#if __IPHONE_OS_VERSION_MIN_REQUIRED < 90000 > > Is this already inside PLATFORM(IOS)? > Yes. We are still interested in building against older iOS SDKs. > > Source/WebCore/platform/spi/cocoa/AVKitSPI.h:104 > > +#if __IPHONE_OS_VERSION_MIN_REQUIRED < 90000 > > Ditto. > See my remark above. > > Source/WebKit2/Platform/spi/ios/SafariServicesSPI.h:46 > > +@interface SFSafariViewController : UIViewController > > Isn't SFSafariViewController public? Oops! Will import header <SafariServices/SFSafariViewController.h> to pick up definition of SFSafariViewController. Committed r190336: <http://trac.webkit.org/changeset/190336> |