Bug 149639

Summary:

[Win] Allow 'prepare-ChangeLog' to be used without Cygwin

Product:

WebKit

Reporter:

Brent Fulgham <bfulgham>

Component:

Tools / Tests

Assignee:

Brent Fulgham <bfulgham>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, bfulgham, commit-queue, dbates, lforschler

Priority:

Version:

WebKit Nightly Build

Hardware:

OS:

All

Attachments:

Description	Flags
Patch	none
Patch v2 (correct sub declaration)	achristensen: review+

Brent Fulgham

Reported 2015-09-29 13:26:19 PDT

Revise the file handling and work around some Windows Perl idiosyncracies to support running the 'prepare-ChangeLog' command without needing Cygwin.

Attachments
Patch (8.67 KB, patch) 2015-09-29 13:36 PDT, Brent Fulgham	no flags	Details Formatted Diff Diff
Patch v2 (correct sub declaration) (8.67 KB, patch) 2015-09-29 13:39 PDT, Brent Fulgham	achristensen: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Brent Fulgham

Comment 1 2015-09-29 13:36:20 PDT

Brent Fulgham

Comment 2 2015-09-29 13:38:19 PDT

Comment on attachment 262099 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=262099&action=review > Tools/Scripts/prepare-ChangeLog:110 > +sub resolveChangeLogsPath(@); Crap. This should be resolveChangeLogsPath($@). I'll upload a fix.

Brent Fulgham

Comment 3 2015-09-29 13:39:21 PDT

Created attachment 262100 [details] Patch v2 (correct sub declaration)

Alex Christensen

Comment 4 2015-09-29 13:48:32 PDT

Comment on attachment 262100 [details] Patch v2 (correct sub declaration) r=me

Brent Fulgham

Comment 5 2015-09-29 14:17:02 PDT

Note You need to log in before you can comment on or make changes to this bug.