Bug 149639 - [Win] Allow 'prepare-ChangeLog' to be used without Cygwin
Summary: [Win] Allow 'prepare-ChangeLog' to be used without Cygwin
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: PC All
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-29 13:26 PDT by Brent Fulgham
Modified: 2015-09-29 14:17 PDT (History)
5 users (show)

See Also:

Attachments
Patch (8.67 KB, patch)
2015-09-29 13:36 PDT, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Patch v2 (correct sub declaration) (8.67 KB, patch)
2015-09-29 13:39 PDT, Brent Fulgham 		achristensen: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2015-09-29 13:26:19 PDT 
Revise the file handling and work around some Windows Perl idiosyncracies to support running the 'prepare-ChangeLog' command without needing Cygwin.
Comment 1 Brent Fulgham 2015-09-29 13:36:20 PDT 
Created attachment 262099 [details]
Patch
Comment 2 Brent Fulgham 2015-09-29 13:38:19 PDT 
Comment on attachment 262099 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262099&action=review

> Tools/Scripts/prepare-ChangeLog:110
> +sub resolveChangeLogsPath(@);

Crap. This should be resolveChangeLogsPath($@). I'll upload a fix.
Comment 3 Brent Fulgham 2015-09-29 13:39:21 PDT 
Created attachment 262100 [details]
Patch v2 (correct sub declaration)
Comment 4 Alex Christensen 2015-09-29 13:48:32 PDT 
Comment on attachment 262100 [details]
Patch v2 (correct sub declaration)

r=me
Comment 5 Brent Fulgham 2015-09-29 14:17:02 PDT 
Committed r190328: <http://trac.webkit.org/changeset/190328>