Bug 149599

Summary:

js/regress/getter-richards-try-catch is timing out on debug layout tests

Product:

WebKit

Reporter:

Saam Barati <saam>

Component:

JavaScriptCore

Assignee:

Saam Barati <saam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, commit-queue, ryanhaddad

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	none

Saam Barati

Reported 2015-09-28 11:01:36 PDT

...

Attachments
patch (1.71 KB, patch) 2015-09-28 11:03 PDT, Saam Barati	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Saam Barati

Comment 1 2015-09-28 11:03:58 PDT

Created attachment 262013 [details] patch

Saam Barati

Comment 2 2015-09-28 11:04:37 PDT

(In reply to comment #1) > Created attachment 262013 [details] > patch This is a speculative fix. I couldn't reproduce this timeout locally. I'll continue to lower the number of iterations until it doesn't time out.

WebKit Commit Bot

Comment 3 2015-09-28 11:57:50 PDT

Comment on attachment 262013 [details] patch Clearing flags on attachment: 262013 Committed r190282: <http://trac.webkit.org/changeset/190282>

WebKit Commit Bot

Comment 4 2015-09-28 11:57:53 PDT

All reviewed patches have been landed. Closing bug.

Ryan Haddad

Comment 5 2015-09-28 14:53:06 PDT

This test is still flaking on all debug bots: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=js%2Fregress%2Fgetter-richards-try-catch.html

Alexey Proskuryakov

Comment 6 2015-09-28 15:39:17 PDT

Is this test worth the time it takes? Generally, tests shouldn't take more than a second (and ideally, a few milliseconds). If a test takes 10 seconds, it's the cost we pay forever going forward.

Saam Barati

Comment 7 2015-09-28 15:53:25 PDT

(In reply to comment #6) > Is this test worth the time it takes? Generally, tests shouldn't take more > than a second (and ideally, a few milliseconds). If a test takes 10 seconds, > it's the cost we pay forever going forward. Probably not worth it. I'll further lower the iteration count.

Saam Barati

Comment 8 2015-09-28 16:06:24 PDT

follow up: http://trac.webkit.org/changeset/190294

Saam Barati

Comment 9 2015-09-28 16:47:08 PDT

follow up #2: disabled on debug builds. http://trac.webkit.org/changeset/190296

Note You need to log in before you can comment on or make changes to this bug.