149599 – js/regress/getter-richards-try-catch is timing out on debug layout tests

Bug 149599 - js/regress/getter-richards-try-catch is timing out on debug layout tests

Summary: js/regress/getter-richards-try-catch is timing out on debug layout tests

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	JavaScriptCore (show other bugs)
Version:	WebKit Nightly Build
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Saam Barati

URL:
Keywords:

Depends on:
Blocks:

Reported:	2015-09-28 11:01 PDT by Saam Barati
Modified:	2015-09-28 16:47 PDT (History)
CC List:	3 users (show)

See Also:

Attachments
patch (1.71 KB, patch) 2015-09-28 11:03 PDT, Saam Barati	no flags	Details \| Formatted Diff \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Saam Barati 2015-09-28 11:01:36 PDT

...

Comment 1 Saam Barati 2015-09-28 11:03:58 PDT

Created attachment 262013 [details]
patch

Comment 2 Saam Barati 2015-09-28 11:04:37 PDT

(In reply to comment #1)
> Created attachment 262013 [details]
> patch

This is a speculative fix. I couldn't reproduce this timeout locally. I'll continue to lower the number of iterations until it doesn't time out.

Comment 3 WebKit Commit Bot 2015-09-28 11:57:50 PDT

Comment on attachment 262013 [details]
patch

Clearing flags on attachment: 262013

Committed r190282: <http://trac.webkit.org/changeset/190282>

Comment 4 WebKit Commit Bot 2015-09-28 11:57:53 PDT

All reviewed patches have been landed.  Closing bug.

Comment 5 Ryan Haddad 2015-09-28 14:53:06 PDT

This test is still flaking on all debug bots:
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=js%2Fregress%2Fgetter-richards-try-catch.html

Comment 6 Alexey Proskuryakov 2015-09-28 15:39:17 PDT

Is this test worth the time it takes? Generally, tests shouldn't take more than a second (and ideally, a few milliseconds). If a test takes 10 seconds, it's the cost we pay forever going forward.

Comment 7 Saam Barati 2015-09-28 15:53:25 PDT

(In reply to comment #6)
> Is this test worth the time it takes? Generally, tests shouldn't take more
> than a second (and ideally, a few milliseconds). If a test takes 10 seconds,
> it's the cost we pay forever going forward.

Probably not worth it.
I'll further lower the iteration count.

Comment 8 Saam Barati 2015-09-28 16:06:24 PDT

follow up:
http://trac.webkit.org/changeset/190294

Comment 9 Saam Barati 2015-09-28 16:47:08 PDT

follow up #2:
disabled on debug builds.
http://trac.webkit.org/changeset/190296