Bug 149582

Summary: GCThread machinery should be release-only
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED WONTFIX    
Severity: Normal CC: benjamin, cmarcelo, commit-queue
Priority: P2    
Version: Other   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch
none
the patch
none
the patch
mitz: review+
patch for landing
none
patch for landing none

Filip Pizlo
Reported 2015-09-26 13:04:29 PDT
Patch forthcoming.
Attachments
the patch (3.59 KB, patch)
2015-09-26 13:05 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (3.60 KB, patch)
2015-09-26 13:07 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (3.62 KB, patch)
2015-09-26 13:10 PDT, Filip Pizlo 		mitz: review+
DetailsFormatted DiffDiff
patch for landing (2.40 KB, patch)
2015-09-26 13:22 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
patch for landing (2.70 KB, patch)
2015-09-26 13:30 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2015-09-26 13:05:56 PDT
Created attachment 261973 [details] the patch
Filip Pizlo
Comment 2 2015-09-26 13:07:33 PDT
Created attachment 261974 [details] the patch
Filip Pizlo
Comment 3 2015-09-26 13:10:54 PDT
Created attachment 261975 [details] the patch
mitz
Comment 4 2015-09-26 13:17:32 PDT
Comment on attachment 261975 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=261975&action=review > Source/WTF/wtf/MainThread.h:71 > +inline bool isMainThreadOrGCThread() { return true; } Since isMainThreadOrGCThread() is only used in assertions and this version is useless, can you just omit it altogether in the ASSERT_DISABLED case?
Filip Pizlo
Comment 5 2015-09-26 13:20:03 PDT
(In reply to comment #4) > Comment on attachment 261975 [details] > the patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=261975&action=review > > > Source/WTF/wtf/MainThread.h:71 > > +inline bool isMainThreadOrGCThread() { return true; } > > Since isMainThreadOrGCThread() is only used in assertions and this version > is useless, can you just omit it altogether in the ASSERT_DISABLED case? Yeah, that's better! I'll try that.
Filip Pizlo
Comment 6 2015-09-26 13:22:24 PDT
Created attachment 261976 [details] patch for landing
Filip Pizlo
Comment 7 2015-09-26 13:30:35 PDT
Created attachment 261977 [details] patch for landing
Filip Pizlo
Comment 8 2015-10-03 15:51:29 PDT
Meh, we don't need this.
Note You need to log in before you can comment on or make changes to this bug.