Summary: | Make custom properties store the parser value list for variable resolution | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dave Hyatt <hyatt> | ||||||||
Component: | Layout and Rendering | Assignee: | Dave Hyatt <hyatt> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, jonlee, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Dave Hyatt
2015-09-24 15:45:36 PDT
Created attachment 261904 [details]
Patch
Attachment 261904 [details] did not pass style-queue:
ERROR: Source/WebCore/css/CSSCustomPropertyValue.h:30: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 1 in 13 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 261905 [details]
Patch
Created attachment 261906 [details]
Patch
Comment on attachment 261906 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=261906&action=review > Source/WebCore/css/CSSComputedStyleDeclaration.cpp:2122 > + Node* styledNode = this->styledNode(); > + if (!styledNode) > + return emptyString(); > + > + RefPtr<RenderStyle> style = computeRenderStyleForProperty(styledNode, m_pseudoElementSpecifier, CSSPropertyCustom); > + if (!style || !style->hasCustomProperty(propertyName)) > + return emptyString(); > + > + return style->getCustomPropertyValue(propertyName)->cssText(); Can't all this use customPropertyValue? Something like RefPtr<CSSValue> propertyValue = this->customPropertyValue(propertyName); return propertyValue ? propertyValue->cssText() : emptyString(); |