| Summary: | Support building for arbitrary architectures | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Daniel Bates <dbates> | ||||||
| Component: | Tools / Tests | Assignee: | Daniel Bates <dbates> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | ap, ddkilzer, dean_johnson, lforschler | ||||||
| Priority: | P2 | ||||||||
| Version: | WebKit Local Build | ||||||||
| Hardware: | iPhone / iPad | ||||||||
| OS: | All | ||||||||
| Attachments: |
|
||||||||
|
Description
Daniel Bates
2015-09-24 13:27:03 PDT
Created attachment 261890 [details]
Patch
Created attachment 261891 [details]
Patch
Updated patch to only pass ARCHS and ONLY_ACTIVE_ARCH to build-webkit when the property architecture is a non-empty string
Comment on attachment 261891 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=261891&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:213 > + self.setCommand(self.command + ['ARCHS=' + architecture, 'ONLY_ACTIVE_ARCH=NO']) Will this work for multiple architectures? (In reply to comment #3) > Comment on attachment 261891 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=261891&action=review > > > Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:213 > > + self.setCommand(self.command + ['ARCHS=' + architecture, 'ONLY_ACTIVE_ARCH=NO']) > > Will this work for multiple architectures? It should. According to <http://docs.buildbot.net/current/manual/cfg-buildsteps.html#buildbot.steps.source.buildbot.steps.shell.ShellCommand> when argument command of a ShellCommand is a list of strings then it is "used directly as an argv array". Committed r190219: <http://trac.webkit.org/changeset/190219> |