Bug 149539

Summary: Support building for arbitrary architectures
Product: WebKit Reporter: Daniel Bates <dbates>
Component: Tools / TestsAssignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, ddkilzer, dean_johnson, lforschler
Priority: P2    
Version: WebKit Local Build   
Hardware: iPhone / iPad   
OS: All   
Attachments:
Description Flags
Patch
none
Patch ap: review+

Daniel Bates
Reported 2015-09-24 13:27:03 PDT
Towards setting up OpenSource iOS device or 32-bit simulator builders we need to teach buildbot to pass the architectures associated with a builder to build-webkit.
Attachments
Patch (1.88 KB, patch)
2015-09-24 13:29 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Patch (1.90 KB, patch)
2015-09-24 13:37 PDT, Daniel Bates 		ap: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2015-09-24 13:29:31 PDT
Created attachment 261890 [details] Patch
Daniel Bates
Comment 2 2015-09-24 13:37:49 PDT
Created attachment 261891 [details] Patch Updated patch to only pass ARCHS and ONLY_ACTIVE_ARCH to build-webkit when the property architecture is a non-empty string
Alexey Proskuryakov
Comment 3 2015-09-24 14:20:40 PDT
Comment on attachment 261891 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=261891&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:213 > + self.setCommand(self.command + ['ARCHS=' + architecture, 'ONLY_ACTIVE_ARCH=NO']) Will this work for multiple architectures?
Daniel Bates
Comment 4 2015-09-24 14:28:25 PDT
(In reply to comment #3) > Comment on attachment 261891 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=261891&action=review > > > Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:213 > > + self.setCommand(self.command + ['ARCHS=' + architecture, 'ONLY_ACTIVE_ARCH=NO']) > > Will this work for multiple architectures? It should. According to <http://docs.buildbot.net/current/manual/cfg-buildsteps.html#buildbot.steps.source.buildbot.steps.shell.ShellCommand> when argument command of a ShellCommand is a list of strings then it is "used directly as an argv array".
Daniel Bates
Comment 5 2015-09-24 14:39:58 PDT
Committed r190219: <http://trac.webkit.org/changeset/190219>
Note You need to log in before you can comment on or make changes to this bug.