Bug 149537

Summary: Web Inspector: JSGlobalRuntimeAgent unintentionally overrides InspectorRuntimeAgent destruction handling
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: DoNotImportToRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix
darin: review+, commit-queue: commit-queue-
[PATCH] For Landing none

Joseph Pecoraro
Reported 2015-09-24 13:10:24 PDT
* SUMMARY JSGlobalRuntimeAgent unintentionally overrides InspectorRuntimeAgent destruction handling. JSGlobalObjectRuntimeAgent::willDestroyFrontendAndBackend - does nothing, should at least call "super" InspectorRuntimeAgent::willDestroyFrontendAndBackend
Attachments
[PATCH] Proposed Fix (3.90 KB, patch)
2015-09-24 13:11 PDT, Joseph Pecoraro 		darin: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
[PATCH] For Landing (2.90 KB, patch)
2015-09-28 18:01 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2015-09-24 13:11:35 PDT
Created attachment 261887 [details] [PATCH] Proposed Fix
WebKit Commit Bot
Comment 2 2015-09-25 10:06:25 PDT
Comment on attachment 261887 [details] [PATCH] Proposed Fix Rejecting attachment 261887 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 261887, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: FAILED -- saving rejects to file Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj.rej patching file Source/JavaScriptCore/inspector/agents/InspectorDebuggerAgent.h patching file Source/JavaScriptCore/inspector/agents/JSGlobalObjectRuntimeAgent.cpp patching file Source/JavaScriptCore/inspector/agents/JSGlobalObjectRuntimeAgent.h Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Darin Adler']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/211203
Joseph Pecoraro
Comment 3 2015-09-28 18:01:50 PDT
Created attachment 262036 [details] [PATCH] For Landing
WebKit Commit Bot
Comment 4 2015-09-28 18:55:55 PDT
Comment on attachment 262036 [details] [PATCH] For Landing Clearing flags on attachment: 262036 Committed r190301: <http://trac.webkit.org/changeset/190301>
Note You need to log in before you can comment on or make changes to this bug.