Bug 149469

Summary: RenderSVGResourceClipper::applyClippingToContext makes an unconditionally unaccelerated ImageBuffer
Product: WebKit Reporter: Tim Horton <thorton>
Component: SVGAssignee: Simon Fraser (smfr) <simon.fraser>
Status: NEW    
Severity: Normal CC: ahmad.saleem792, changseok, dino, esprehn+autocc, ews-watchlist, fmalita, glenn, gyuyoung.kim, kondapallykalyan, pdr, sabouhallawa, schenney, sergio, simon.fraser, zimmermann
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch thorton: review+, ews-feeder: commit-queue-

Tim Horton
Reported 2015-09-22 11:11:47 PDT
The ImageBuffer should inherit the accelerated bit from the context it will eventually be painted into. However, doing so breaks some tests when run with --accelerated-drawing on, and clearly also breaks these tests in Safari. Needs more investigation (and possibly bugs filed on other components).
Attachments
Patch (3.40 KB, patch)
2021-10-16 12:46 PDT, Simon Fraser (smfr) 		thorton: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2021-10-16 12:40:09 PDT
The only one I found in LayoutTests/svg was svg/gradients/spreadMethodClose2.svg which looks like a bug with accelerated drawing.
Simon Fraser (smfr)
Comment 2 2021-10-16 12:41:17 PDT
But svg/gradients/spreadMethodClose2.svg has different behavior in Chrome and Firefox (both of which show blues) so it's not clear what's going on.
Simon Fraser (smfr)
Comment 3 2021-10-16 12:46:19 PDT
Created attachment 441501 [details] Patch
Ahmad Saleem
Comment 4 2022-10-09 06:32:00 PDT
It seems this r+ patch didn't landed and we have FIXME about it as well: https://github.com/WebKit/WebKit/blob/ce878379210ced398d994217e26519b433761149/Source/WebCore/rendering/svg/RenderSVGResourceClipper.cpp#L171 Just wanted to update. Thanks!
Ahmad Saleem
Comment 5 2023-06-14 17:02:00 PDT
NOTE - this patch also still work on WebKit ToT (tested locally).
Note You need to log in before you can comment on or make changes to this bug.