Bug 149445

Summary: Add some style recalc tests for shadow DOM
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Layout and RenderingAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: koivisto
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 148695    
Attachments:
Description Flags
Adds tests koivisto: review+

Description Ryosuke Niwa 2015-09-21 20:34:09 PDT 
Add tests to make sure we trigger necessary style recalc.
Comment 1 Ryosuke Niwa 2015-09-21 20:36:47 PDT 
Created attachment 261718 [details]
Adds tests
Comment 2 Antti Koivisto 2015-09-21 20:58:04 PDT 
Comment on attachment 261718 [details]
Adds tests

View in context: https://bugs.webkit.org/attachment.cgi?id=261718&action=review

> LayoutTests/fast/shadow-dom/shadow-layout-after-host-child-changes.html:42
> +    else
> +        document.querySelector('p').getBoundingClientRect();

Not sure if this is reliable for forcing layout. We might optimize it away.
Comment 3 Ryosuke Niwa 2015-09-21 21:01:14 PDT 
(In reply to comment #2)
> Comment on attachment 261718 [details]
> Adds tests
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=261718&action=review
> 
> > LayoutTests/fast/shadow-dom/shadow-layout-after-host-child-changes.html:42
> > +    else
> > +        document.querySelector('p').getBoundingClientRect();
> 
> Not sure if this is reliable for forcing layout. We might optimize it away.

Yeah, there isn't really a good way to force it within a browser.
Comment 4 Ryosuke Niwa 2015-09-21 21:01:45 PDT 
Committed r190101: <http://trac.webkit.org/changeset/190101>