Bug 149445 - Add some style recalc tests for shadow DOM
Summary: Add some style recalc tests for shadow DOM
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks: 148695
  Show dependency treegraph
 
Reported: 2015-09-21 20:34 PDT by Ryosuke Niwa
Modified: 2015-09-21 21:01 PDT (History)
1 user (show)

See Also:


Attachments
Adds tests (13.06 KB, patch)
2015-09-21 20:36 PDT, Ryosuke Niwa
koivisto: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2015-09-21 20:34:09 PDT
Add tests to make sure we trigger necessary style recalc.
Comment 1 Ryosuke Niwa 2015-09-21 20:36:47 PDT
Created attachment 261718 [details]
Adds tests
Comment 2 Antti Koivisto 2015-09-21 20:58:04 PDT
Comment on attachment 261718 [details]
Adds tests

View in context: https://bugs.webkit.org/attachment.cgi?id=261718&action=review

> LayoutTests/fast/shadow-dom/shadow-layout-after-host-child-changes.html:42
> +    else
> +        document.querySelector('p').getBoundingClientRect();

Not sure if this is reliable for forcing layout. We might optimize it away.
Comment 3 Ryosuke Niwa 2015-09-21 21:01:14 PDT
(In reply to comment #2)
> Comment on attachment 261718 [details]
> Adds tests
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=261718&action=review
> 
> > LayoutTests/fast/shadow-dom/shadow-layout-after-host-child-changes.html:42
> > +    else
> > +        document.querySelector('p').getBoundingClientRect();
> 
> Not sure if this is reliable for forcing layout. We might optimize it away.

Yeah, there isn't really a good way to force it within a browser.
Comment 4 Ryosuke Niwa 2015-09-21 21:01:45 PDT
Committed r190101: <http://trac.webkit.org/changeset/190101>