Bug 149428

Summary: Make it more obvious when using an unaccelerated image buffer, and fix a few callers who do
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, ap, dino, sabouhallawa, sam, simon.fraser
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for EWS none

Description Tim Horton 2015-09-21 15:59:11 PDT
Make it more obvious when using an unaccelerated image buffer, and fix a few callers who do
Comment 1 Tim Horton 2015-09-21 16:03:03 PDT
Created attachment 261696 [details]
Patch
Comment 2 Tim Horton 2015-09-21 16:34:26 PDT
Created attachment 261701 [details]
Patch
Comment 3 Tim Horton 2015-09-22 11:16:13 PDT
Here are the bugs I filed for places where we're still creating unaccelerated image buffers and shouldn't be:

RenderSVGResourceMasker::applyResource https://bugs.webkit.org/show_bug.cgi?id=149470
RenderSVGResourceClipper::applyClippingToContext https://bugs.webkit.org/show_bug.cgi?id=149469
Shape::createRasterShape https://bugs.webkit.org/show_bug.cgi?id=149420
MediaControlTextTrackContainerElement::createTextTrackRepresentationImage https://bugs.webkit.org/show_bug.cgi?id=149422
WebGLRenderingContextBase::LRUImageBufferCache::imageBuffer https://bugs.webkit.org/show_bug.cgi?id=149423
CSSFilterImageValue::image https://bugs.webkit.org/show_bug.cgi?id=149424
ImageBuffer(CG)::putByteArray https://bugs.webkit.org/show_bug.cgi?id=149431

Some of these need more investigation into why making an accelerated buffer fails, some just need plumbing through of a way to know which kind of buffer to make.
Comment 4 Tim Horton 2015-09-22 11:20:00 PDT
Created attachment 261754 [details]
Patch for EWS
Comment 5 Tim Horton 2015-09-22 11:46:53 PDT
http://trac.webkit.org/changeset/190124