Bug 149395

Summary: Implement Store expressions in WebAssembly
Product: WebKit Reporter: Sukolsak Sakshuwong <sukolsak>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fpizlo, ggaren, saam, sukolsak, ysuzuki
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 146064    
Attachments:
Description Flags
Patch
none
Patch none

Sukolsak Sakshuwong
Reported 2015-09-20 23:36:38 PDT
'Store' instructions in WebAssembly can be both statements and expressions. We have implemented them as statements but haven't implemented them as expressions.
Attachments
Patch (18.73 KB, patch)
2015-09-20 23:54 PDT, Sukolsak Sakshuwong 		no flags
DetailsFormatted DiffDiff
Patch (18.71 KB, patch)
2015-09-21 00:00 PDT, Sukolsak Sakshuwong 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sukolsak Sakshuwong
Comment 1 2015-09-20 23:54:56 PDT
Created attachment 261632 [details] Patch
Sukolsak Sakshuwong
Comment 2 2015-09-21 00:00:29 PDT
Created attachment 261633 [details] Patch
Geoffrey Garen
Comment 3 2015-09-21 10:59:51 PDT
Comment on attachment 261633 [details] Patch r=me
WebKit Commit Bot
Comment 4 2015-09-21 11:47:57 PDT
Comment on attachment 261633 [details] Patch Clearing flags on attachment: 261633 Committed r190062: <http://trac.webkit.org/changeset/190062>
WebKit Commit Bot
Comment 5 2015-09-21 11:48:01 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.