Bug 149395 - Implement Store expressions in WebAssembly
Summary: Implement Store expressions in WebAssembly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 146064
  Show dependency treegraph
 
Reported: 2015-09-20 23:36 PDT by Sukolsak Sakshuwong
Modified: 2015-09-21 11:48 PDT (History)
6 users (show)

See Also:


Attachments
Patch (18.73 KB, patch)
2015-09-20 23:54 PDT, Sukolsak Sakshuwong
no flags Details | Formatted Diff | Diff
Patch (18.71 KB, patch)
2015-09-21 00:00 PDT, Sukolsak Sakshuwong
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sukolsak Sakshuwong 2015-09-20 23:36:38 PDT
'Store' instructions in WebAssembly can be both statements and expressions. We have implemented them as statements but haven't implemented them as expressions.
Comment 1 Sukolsak Sakshuwong 2015-09-20 23:54:56 PDT
Created attachment 261632 [details]
Patch
Comment 2 Sukolsak Sakshuwong 2015-09-21 00:00:29 PDT
Created attachment 261633 [details]
Patch
Comment 3 Geoffrey Garen 2015-09-21 10:59:51 PDT
Comment on attachment 261633 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2015-09-21 11:47:57 PDT
Comment on attachment 261633 [details]
Patch

Clearing flags on attachment: 261633

Committed r190062: <http://trac.webkit.org/changeset/190062>
Comment 5 WebKit Commit Bot 2015-09-21 11:48:01 PDT
All reviewed patches have been landed.  Closing bug.