Bug 149379

Summary: [GTK] REGRESSION(188031): ASSERTION FAILED: menu
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: WebKitGTKAssignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, commit-queue, mcatanzaro
Priority: P2    
Version: Other   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch none

Michael Catanzaro
Reported 2015-09-19 18:16:56 PDT
r188031 added the following call in WebContextMenuProxyGtk::CancelTracking: m_menu.setPlatformDescription(nullptr); But the first line of code in setPlatformDescription is an assert to be sure the parameter isn't null. Reminder: now that we have debug fission enabled by default, we can start using debug builds instead of release builds for development, and avoid such issues.
Attachments
Patch (1.26 KB, patch)
2015-09-19 20:26 PDT, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2015-09-19 20:26:35 PDT
Created attachment 261600 [details] Patch
WebKit Commit Bot
Comment 2 2015-09-21 00:22:55 PDT
Comment on attachment 261600 [details] Patch Clearing flags on attachment: 261600 Committed r190045: <http://trac.webkit.org/changeset/190045>
WebKit Commit Bot
Comment 3 2015-09-21 00:22:59 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.