| Summary: | Get rid of most custom bindings for Location.idl | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||
| Component: | Bindings | Assignee: | Chris Dumez <cdumez> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, darin, ggaren, kling, rniwa, sam | ||||
| Priority: | P2 | ||||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Chris Dumez
2015-09-19 09:22:47 PDT
Created attachment 261581 [details]
Patch
Comment on attachment 261581 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=261581&action=review I think it’s strange that the extra arguments that give context to the setter come *before* the attribute value itself. > Source/WebCore/bindings/js/JSDocumentCustom.cpp:68 > +// FIXME: Require support for [PutForward=XXX] Web IDL extended attribute. I don’t think this is a very clear comment. I think what it means is that setting location isn’t correct until we add support for PutForward to the JavaScript bindings generator and then use it for the location attribute. But if that’s what it means, the wording is not really clear about that. > Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:3180 > + push(@callWithArgs, "exec") if $codeGenerator->ExtendedAttributeContains($callWith, "ScriptState"); Sure wish this would pass *exec instead of exec. We should start using the type ExecState& instead of ExecState* in new things we create. Comment on attachment 261581 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=261581&action=review >> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:3180 >> + push(@callWithArgs, "exec") if $codeGenerator->ExtendedAttributeContains($callWith, "ScriptState"); > > Sure wish this would pass *exec instead of exec. We should start using the type ExecState& instead of ExecState* in new things we create. Yes, I can do this in a follow-up. Comment on attachment 261581 [details] Patch Clearing flags on attachment: 261581 Committed r190017: <http://trac.webkit.org/changeset/190017> All reviewed patches have been landed. Closing bug. Follow-up GTK build fixes: <https://trac.webkit.org/r190038> <https://trac.webkit.org/r190039> |