Bug 149362

Summary: Layout milestones aren't synchronized with UI-side compositing transactions
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, commit-queue, mitz, sam, simon.fraser
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Tim Horton
Reported 2015-09-18 18:15:47 PDT
Layout milestones aren't synchronized with UI-side compositing transactions
Attachments
Patch (24.50 KB, patch)
2015-09-18 18:16 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (24.98 KB, patch)
2015-09-21 11:51 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (25.09 KB, patch)
2015-09-21 11:52 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2015-09-18 18:16:25 PDT
Created attachment 261550 [details] Patch
mitz
Comment 2 2015-09-18 19:02:55 PDT
Comment on attachment 261550 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=261550&action=review > Source/WebKit2/Shared/mac/RemoteLayerTreeTransaction.h:263 > + WebCore::LayoutMilestones m_newlyReachedLayoutMilestones; Can this be initializer here… > Source/WebKit2/Shared/mac/RemoteLayerTreeTransaction.mm:493 > + , m_newlyReachedLayoutMilestones(0) …instead of here? > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:5041 > + // Clients should not set userData for this message, and it won't be passed through. > + ASSERT(!userData); Doesn’t make sense to have an assertion about the behavior of client code. Does make sense to rev the client interface to remove the user data.
Tim Horton
Comment 3 2015-09-18 21:33:32 PDT
(In reply to comment #2) > Comment on attachment 261550 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=261550&action=review > > > Source/WebKit2/Shared/mac/RemoteLayerTreeTransaction.h:263 > > + WebCore::LayoutMilestones m_newlyReachedLayoutMilestones; > > Can this be initializer here… > > > Source/WebKit2/Shared/mac/RemoteLayerTreeTransaction.mm:493 > > + , m_newlyReachedLayoutMilestones(0) > > …instead of here? Definitely. > > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:5041 > > + // Clients should not set userData for this message, and it won't be passed through. > > + ASSERT(!userData); > > Doesn’t make sense to have an assertion about the behavior of client code. Hmm, that was an Anders plan. But ok! > Does make sense to rev the client interface to remove the user data. OK.
Tim Horton
Comment 4 2015-09-21 11:51:30 PDT
Created attachment 261669 [details] Patch
Tim Horton
Comment 5 2015-09-21 11:52:06 PDT
Created attachment 261671 [details] Patch
WebKit Commit Bot
Comment 6 2015-09-21 12:03:50 PDT
Comment on attachment 261671 [details] Patch Clearing flags on attachment: 261671 Committed r190064: <http://trac.webkit.org/changeset/190064>
WebKit Commit Bot
Comment 7 2015-09-21 12:03:55 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.