Bug 149359

Summary: VariableEnvironmentNode should inherit from ParserArenaDeletable because VariableEnvironment's must have their destructors run
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, thorton
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch none

Saam Barati
Reported 2015-09-18 16:13:52 PDT
We are leaking HashMaps.
Attachments
patch (5.42 KB, patch)
2015-09-18 17:02 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
patch (5.45 KB, patch)
2015-09-18 17:04 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2015-09-18 17:02:19 PDT
Created attachment 261545 [details] patch
Saam Barati
Comment 2 2015-09-18 17:04:50 PDT
Created attachment 261546 [details] patch
Andreas Kling
Comment 3 2015-09-19 05:10:16 PDT
Comment on attachment 261546 [details] patch Good catch. r=me
WebKit Commit Bot
Comment 4 2015-09-19 08:37:03 PDT
Comment on attachment 261546 [details] patch Clearing flags on attachment: 261546 Committed r190014: <http://trac.webkit.org/changeset/190014>
WebKit Commit Bot
Comment 5 2015-09-19 08:37:06 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.