Bug 149351

Summary:

isGitSVNDirectory() returns true when Git is not installed

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

Tools / Tests

Assignee:

Daniel Bates <dbates>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, ap

Priority:

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none

Daniel Bates

Reported 2015-09-18 12:47:13 PDT

If Git is not installed then VCSUtils::isGitSVNDirectory() will return true for an arbitrary directory.

Attachments
Patch (1.46 KB, patch) 2015-09-18 12:48 PDT, Daniel Bates	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Daniel Bates

Comment 1 2015-09-18 12:48:47 PDT

Created attachment 261510 [details] Patch

Alexey Proskuryakov

Comment 2 2015-09-18 12:52:48 PDT

Comment on attachment 261510 [details] Patch Looks fine as a short term fix, however doesn't this leave us with an error in console? Ideally, we should build without errors or warnings, so that new important errors don't get hidden in the noise.

Daniel Bates

Comment 3 2015-09-18 12:59:48 PDT

(In reply to comment #2) > Comment on attachment 261510 [details] > Patch > > Looks fine as a short term fix, however doesn't this leave us with an error > in console? No, it does not leave an error in the console.

Daniel Bates

Comment 4 2015-09-18 13:01:02 PDT

Comment on attachment 261510 [details] Patch Clearing flags on attachment: 261510 Committed r189977: <http://trac.webkit.org/changeset/189977>

Daniel Bates

Comment 5 2015-09-18 13:01:06 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.