Bug 149351

Summary:

isGitSVNDirectory() returns true when Git is not installed

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

Tools / Tests

Assignee:

Daniel Bates <dbates>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, ap

Priority:

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none

Description Daniel Bates 2015-09-18 12:47:13 PDT

If Git is not installed then VCSUtils::isGitSVNDirectory() will return true for an arbitrary directory.

Comment 1 Daniel Bates 2015-09-18 12:48:47 PDT

Created attachment 261510 [details]
Patch

Comment 2 Alexey Proskuryakov 2015-09-18 12:52:48 PDT

Comment on attachment 261510 [details]
Patch

Looks fine as a short term fix, however doesn't this leave us with an error in console? Ideally, we should build without errors or warnings, so that new important errors don't get hidden in the noise.

Comment 3 Daniel Bates 2015-09-18 12:59:48 PDT

(In reply to comment #2)
> Comment on attachment 261510 [details]
> Patch
> 
> Looks fine as a short term fix, however doesn't this leave us with an error
> in console? 

No, it does not leave an error in the console.

Comment 4 Daniel Bates 2015-09-18 13:01:02 PDT

Comment on attachment 261510 [details]
Patch

Clearing flags on attachment: 261510

Committed r189977: <http://trac.webkit.org/changeset/189977>

Comment 5 Daniel Bates 2015-09-18 13:01:06 PDT

All reviewed patches have been landed.  Closing bug.