| Summary: | AX: aria-hidden=false causes video fallback content to be exposed to AX API | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | James Craig <jcraig> | ||||||||
| Component: | Accessibility | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | aboxhall, apinheiro, cfleizach, commit-queue, dmazzoni, jdiggs, mario, n_wang, samuel_white, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | Safari 9 | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 275243 [details]
patch
Comment on attachment 275243 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=275243&action=review > Source/WebCore/ChangeLog:12 > + No new tests. should mention the updated test > Source/WebCore/accessibility/AXObjectCache.cpp:2518 > + if (testNode->renderer() != nil) if (!testNode->renderer()) Comment on attachment 275243 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=275243&action=review >> Source/WebCore/accessibility/AXObjectCache.cpp:2518 >> + if (testNode->renderer() != nil) > > if (!testNode->renderer()) I think you mean if(testNode->renderer()) ? Created attachment 275244 [details]
patch
review comments
Comment on attachment 275244 [details] patch Clearing flags on attachment: 275244 Committed r198895: <http://trac.webkit.org/changeset/198895> All reviewed patches have been landed. Closing bug. |
Created attachment 261411 [details] test case AX: aria-hidden=false causes video fallback content to be exposed to AX API aria-hidden="false" should only affect the node (<div>) and immediate child text nodes. In this case, it is causing a grandchild text node to be exposed.