Bug 149278

Summary: AX: aria-hidden=false causes video fallback content to be exposed to AX API
Product: WebKit Reporter: James Craig <jcraig>
Component: AccessibilityAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, commit-queue, dmazzoni, jdiggs, mario, n_wang, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Safari 9   
Hardware: All   
OS: All   
Attachments:
Description Flags
test case
none
patch
none
patch none

James Craig
Reported 2015-09-17 12:46:06 PDT
Created attachment 261411 [details] test case AX: aria-hidden=false causes video fallback content to be exposed to AX API aria-hidden="false" should only affect the node (<div>) and immediate child text nodes. In this case, it is causing a grandchild text node to be exposed.
Attachments
test case (177 bytes, text/html)
2015-09-17 12:46 PDT, James Craig 		no flags
Details
patch (4.08 KB, patch)
2016-03-30 17:36 PDT, Nan Wang 		no flags
DetailsFormatted DiffDiff
patch (4.14 KB, patch)
2016-03-30 17:49 PDT, Nan Wang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-09-17 12:46:41 PDT
<rdar://problem/22744328>
Nan Wang
Comment 2 2016-03-30 17:36:35 PDT
Created attachment 275243 [details] patch
chris fleizach
Comment 3 2016-03-30 17:43:12 PDT
Comment on attachment 275243 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=275243&action=review > Source/WebCore/ChangeLog:12 > + No new tests. should mention the updated test > Source/WebCore/accessibility/AXObjectCache.cpp:2518 > + if (testNode->renderer() != nil) if (!testNode->renderer())
Nan Wang
Comment 4 2016-03-30 17:48:21 PDT
Comment on attachment 275243 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=275243&action=review >> Source/WebCore/accessibility/AXObjectCache.cpp:2518 >> + if (testNode->renderer() != nil) > > if (!testNode->renderer()) I think you mean if(testNode->renderer()) ?
Nan Wang
Comment 5 2016-03-30 17:49:14 PDT
Created attachment 275244 [details] patch review comments
WebKit Commit Bot
Comment 6 2016-03-31 09:17:14 PDT
Comment on attachment 275244 [details] patch Clearing flags on attachment: 275244 Committed r198895: <http://trac.webkit.org/changeset/198895>
WebKit Commit Bot
Comment 7 2016-03-31 09:17:18 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.