Bug 149276

Summary: Refactor common code between GetCatchHandlerFunctor and UnwindFunctor
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, fpizlo, ggaren, keith_miller, mark.lam, msaboff, oliver, ysuzuki
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch mark.lam: review+

Saam Barati
Reported 2015-09-17 12:03:44 PDT
There is a lot of duplicate code between them. We should probably reuse the code, and just add another field to UnwindFunctor to give it a "search" mode that doesn't copyCalleeSaves and also unwinds past VM entry frames.
Attachments
patch (6.71 KB, patch)
2015-09-17 18:53 PDT, Saam Barati 		mark.lam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2015-09-17 18:27:58 PDT
Change of plans. I'm keeping two separate functors and just writing a function to be shared between them.
Saam Barati
Comment 2 2015-09-17 18:53:46 PDT
Created attachment 261472 [details] patch
Mark Lam
Comment 3 2015-09-18 09:31:54 PDT
Comment on attachment 261472 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=261472&action=review Looks good. r=me > Source/JavaScriptCore/ChangeLog:3 > + Abstract some common code between GetCatchHandlerFunctor and UnwindFunctor Do you mean "Extract" instead of "Abstract"? Or perhaps "Refactor common code out of Get...".
Saam Barati
Comment 4 2015-09-18 18:27:14 PDT
landed in: http://trac.webkit.org/changeset/190004
Note You need to log in before you can comment on or make changes to this bug.