Bug 149274

Summary: Web Inspector: Inactive window may cause many layers to be created due to Dashboard opacity
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[IMAGE] Window Active
none
[IMAGE] Window Inactive (Issue)
none
[PATCH] Proposed Fix
none
[IMAGE] With Fix none

Description Joseph Pecoraro 2015-09-17 11:13:48 PDT
* SUMMARY
Inactive window may cause many layers to be created due to Dashboard opacity.

See attached screenshots.

* STEPS TO REPRODUCE
1. Inspect a page
2. Pause
3. Make the window inactive
  => lots of layers
Comment 1 Radar WebKit Bug Importer 2015-09-17 11:14:08 PDT
<rdar://problem/22742333>
Comment 2 Joseph Pecoraro 2015-09-17 11:16:16 PDT
Created attachment 261401 [details]
[IMAGE] Window Active
Comment 3 Joseph Pecoraro 2015-09-17 11:16:35 PDT
Created attachment 261402 [details]
[IMAGE] Window Inactive (Issue)
Comment 4 Joseph Pecoraro 2015-09-17 11:18:34 PDT
The issue appears to be because of the opacity:

    body.latest-mac.window-inactive .toolbar .dashboard-container {
        opacity: 0.65;
        ...
    }

Which contains an animating element. This then uses a cascade of overlapping elements.

A possible workaround might be:

    body.latest-mac.window-inactive .toolbar .dashboard-container > *
        opacity: 0.65;
    }
Comment 5 Joseph Pecoraro 2015-09-17 11:27:49 PDT
> A possible workaround might be:

Naw that isn't good, it causes a few other issues and making it work starts being ugly.

An easy solution, stop the animation when the window is inactive!
Comment 6 Joseph Pecoraro 2015-09-17 11:32:17 PDT
Created attachment 261405 [details]
[PATCH] Proposed Fix
Comment 7 Joseph Pecoraro 2015-09-17 11:32:29 PDT
Created attachment 261406 [details]
[IMAGE] With Fix
Comment 8 BJ Burg 2015-09-17 11:42:09 PDT
Comment on attachment 261405 [details]
[PATCH] Proposed Fix

r=me
Comment 9 WebKit Commit Bot 2015-09-17 12:28:49 PDT
Comment on attachment 261405 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 261405

Committed r189923: <http://trac.webkit.org/changeset/189923>
Comment 10 WebKit Commit Bot 2015-09-17 12:28:52 PDT
All reviewed patches have been landed.  Closing bug.